Re: [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

[Kevin Hilman <khilman@deeprootsystems.com>]

Hugo Villeneuve <hugo@hugovil.com> writes:

> On Tue, 10 Mar 2009 15:16:32 +0000
> Mark Brown <broonie@sirena.org.uk> wrote:
>
>> On Tue, Mar 10, 2009 at 10:03:41AM -0400, Hugo Villeneuve wrote:
>> 
>> > I based those patches on the latest linux-davinci git tree, which
>> > has the function.
>> 
>> Do not submit patches for mainline which are not based on mainline
>> trees.  Code which relies on out of tree changes needs to wait for
>> those out of tree changes to be merged before submitting to mainline.
>
> I did not know that these changes were not in mainline yet. I was told
> that all davinci ASoC code changes were to be submitted only to ALSA,
> and then were imported back into the davinci git tree. Apparently this
> is not quite like that anymore.
>
> Kevin, what is the new rule to submit davinci ASoC patches?
>

The DaVinci ASoC code is indeed in mainline, but not all of the
DaVinci core (in this case the pin mux) is yet in mainline.  I will be
pushing it during the next merge window.

On a related note, sound/soc/davinci/davinci-[evm,sffsdr].c is
actually board-level setup code and should not actually live in
sound/asoc/.  It should live in arch/arm/mach-davinci/* and follow the
rest of the davinci chip/board code upstream.

Kevin