All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: davinci-linux-open-source@linux.davincidsp.com,
	alsa-devel@alsa-project.org, Hugo Villeneuve <hugo@hugovil.com>
Subject: Re: [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR
Date: Tue, 10 Mar 2009 09:08:38 -0700	[thread overview]
Message-ID: <87d4cptl6h.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20090310160207.GE12297@sirena.org.uk> (Mark Brown's message of "Tue\, 10 Mar 2009 16\:02\:10 +0000")

Mark Brown <broonie@sirena.org.uk> writes:

> On Tue, Mar 10, 2009 at 08:55:06AM -0700, Kevin Hilman wrote:
>
>> On a related note, sound/soc/davinci/davinci-[evm,sffsdr].c is
>> actually board-level setup code and should not actually live in
>> sound/asoc/.  It should live in arch/arm/mach-davinci/* and follow the
>> rest of the davinci chip/board code upstream.
>
> No, the ASoC APIs are not stable enough for this - putting this code in
> arch/arm will just lead to merge pain when code from one tree goes in
> without updates from the other.
>
> Experience also suggests that audio drivers often get substantial enough
> and need sufficient review to warrant keeping separate from the core
> machine code.

OK, good to know your opinion there.

Thanks,

Kevin

  reply	other threads:[~2009-03-10 16:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-10  3:32 Fix audio for Lyrtech SFFSDR board Hugo Villeneuve
2009-03-10  3:32 ` [PATCH 1/4] ALSA: ASoC: Davinci: Fix SFFSDR FPGA module codec FS bug Hugo Villeneuve
2009-03-10 15:53   ` Mark Brown
2009-03-10  3:32 ` [PATCH 2/4] ALSA: ASoC: Davinci: Replaced DAI format RIGHT_J by DSP_B for SFFSDR Hugo Villeneuve
     [not found] ` <1236655929-31688-1-git-send-email-hugo-rg2e/+w5TaNBDgjK7y7TUQ@public.gmane.org>
2009-03-10  3:32   ` [PATCH 3/4] ALSA: ASoC: Davinci: Updated sffsdr_hw_params() function to new format Hugo Villeneuve
2009-03-10  3:32   ` [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR Hugo Villeneuve
     [not found]     ` <20090310102921.GA12297@sirena.org.uk>
2009-03-10 14:03       ` Hugo Villeneuve
2009-03-10 15:16         ` Mark Brown
2009-03-10 15:42           ` Hugo Villeneuve
2009-03-10 15:55             ` Kevin Hilman
2009-03-10 16:02               ` Mark Brown
2009-03-10 16:08                 ` Kevin Hilman [this message]
2009-03-10 16:04               ` Hugo Villeneuve
2009-03-10 16:20                 ` Kevin Hilman
2009-03-10 17:07                   ` Hugo Villeneuve
2009-03-10 17:11                     ` Kevin Hilman
2009-03-10 18:10                       ` David Brownell
2009-03-10 19:42                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4cptl6h.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=hugo@hugovil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.