All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] pc & gpt partmap iterators don't abort when their hook requests it
Date: Thu, 03 Jul 2008 20:31:05 +0200	[thread overview]
Message-ID: <87hcb66cra.fsf@xs4all.nl> (raw)
In-Reply-To: <20080701153337.GA6154@thorin> (Robert Millan's message of "Tue,  1 Jul 2008 17:33:37 +0200")

Robert Millan <rmh@aybabtu.com> writes:

> On Tue, Jul 01, 2008 at 03:25:32PM +0200, Robert Millan wrote:
>> 
>> See ChangeLog for description.  I'd really like to receive some review on
>> this one, since the code it touches is so fragile (although I tested it on a
>> typical setup and it works).
>
> Tough luck.  Inmediately after this I noticed it breaks grub-setup (I tested it
> by loading core.img directly).
>
> I found a few other callers that relied on the buggy behaviour.  Here's a new
> patch.

Thanks for fixing this.  I had a quick look and it looks sane at first
sight.  Did you have a look at the other modules as well?

--
Marco




  reply	other threads:[~2008-07-03 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 13:25 [PATCH] pc & gpt partmap iterators don't abort when their hook requests it Robert Millan
2008-07-01 15:33 ` Robert Millan
2008-07-03 18:31   ` Marco Gerards [this message]
2008-07-03 22:57     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hcb66cra.fsf@xs4all.nl \
    --to=mgerards@xs4all.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.