bug in jiffy time comparison macros

bug in jiffy time comparison macros

[Ralph Campbell]

It may just be me :-) but this looks like a bug:
In the current include/linux/jiffies.h:

#define time_before(a,b)        time_after(b,a)

Shouldn't this be:

#define time_before(a,b)        time_after_eq(b,a)

There are a number of similar macros which fail
to change before to after_eq, or before_eq to after,
etc.

Re: bug in jiffy time comparison macros

[Johannes Weiner]

Hi,

Ralph Campbell <ralph.campbell@qlogic.com> writes:

> It may just be me :-) but this looks like a bug:
> In the current include/linux/jiffies.h:
>
> #define time_before(a,b)        time_after(b,a)
>
> Shouldn't this be:
>
> #define time_before(a,b)        time_after_eq(b,a)

Then it would be time_before_eq()..?

If a is before b, b must be after a.  If they might be equal, than from
both points of view.

	Hannes