[PATCH] Make 'xm save' sanity check the path

[PATCH] Make 'xm save' sanity check the path

[Dan Smith]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

This patch adds a quick check in "xm save" to make sure the path given
exists, and is writable.

This will fix the issue detected by xm-test 03_save_bogusfile_neg.

Signed-off-by: Dan Smith <danms@us.ibm.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: save-checkwrite.patch --]
[-- Type: text/x-patch, Size: 523 bytes --]

diff -r 5ea81e640509 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py	Sun Sep 25 10:47:22 2005
+++ b/tools/python/xen/xm/main.py	Mon Sep 26 09:32:32 2005
@@ -175,6 +175,10 @@
 
     dom = args[0] # TODO: should check if this exists
     savefile = os.path.abspath(args[1])
+
+    if not os.access(os.path.dirname(savefile), os.W_OK):
+        err("xm save: Unable to create file %s" % savefile)
+        sys.exit(1)
     
     from xen.xend.XendClient import server
     server.xend_domain_save(dom, savefile)

[-- Attachment #3: Type: text/plain, Size: 87 bytes --]

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@us.ibm.com

[-- Attachment #4: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] Make 'xm save' sanity check the path

[Ewan Mellor]

On Mon, Sep 26, 2005 at 10:16:15AM -0700, Dan Smith wrote:

> This patch adds a quick check in "xm save" to make sure the path given
> exists, and is writable.
> 
> This will fix the issue detected by xm-test 03_save_bogusfile_neg.
> 
> Signed-off-by: Dan Smith <danms@us.ibm.com>

Applied, thanks.

Ewan.