All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Completion for arguments
Date: Mon, 29 Aug 2005 17:27:34 +0200	[thread overview]
Message-ID: <87hdd8pxuh.fsf@student.han.nl> (raw)
In-Reply-To: <200508281437.19326.okuji@enbug.org> (Yoshinori K. Okuji's message of "Sun, 28 Aug 2005 14:37:19 +0200")

"Yoshinori K. Okuji" <okuji@enbug.org> writes:

> On Saturday 27 August 2005 00:11, Marco Gerards wrote:
>> +  /* Add the short arguments.  */
>> +  for (option = cmd->options; option->doc; option++)
>> +    {
>> +      if (!option->shortarg)
>> +	continue;
>
> This should be:
>
>   if (! grub_isgraph (option->shortarg))
>     continue;
>
> because we sometimes want to specify non-graph short arguments for 
> convenience.

You are right, I will fix this next time when I commit a patch.

Thanks,
Marco




      reply	other threads:[~2005-08-29 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-26 22:11 Completion for arguments Marco Gerards
2005-08-28 12:37 ` Yoshinori K. Okuji
2005-08-29 15:27   ` Marco Gerards [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hdd8pxuh.fsf@student.han.nl \
    --to=metgerards@student.han.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.