Re: [PATCH] Kernel support for VESA Bios Extension

[Marco Gerards <metgerards@student.han.nl>]

Vesa Jääskeläinen <chaac@nic.fi> writes:

Hi,

Thanks a lot for your work.  I am looking forwards to the VESA
console!

> Here is attached a patch that adds VBE support to kernel and include
> file to make it easier to use it. There is diff for both i386-pc.rmk
> and i386-pc.mk. Latter could be removed and let build process to
> generate it again, but I think that .mk file is present in CVS so I
> left both there.

Please always include the changed to *.rmk in the patches.  You don't
have to supply *.mk because those files are generated and make the
patch just harder to read.

> I will make separate patch for the frame buffer console after this is
> first committed. (And I need to make some cleanups there first)

Ok.

> I would like to hear comments about the patch. I tried to implement
> most commonly needed functions, so you can't do everything with
> this. As I didn't need to use every function in my frame buffer
> console test, some things might not work. But I tried to make my best
> to proof read every function.

Can you please make sure you are using the GCS for coding style?
Please have a look at the other sourcecode and the GCS (GNU Coding
Standards) first:

http://www.gnu.org/prep/standards/

It is important for us to have a single and consistent coding style.
If you have questions about either GRUB or the coding style you are of
course free to ask.

Thanks,
Marco