Re: suspend command patch

[Marco Gerards <metgerards@student.han.nl>]

Hollis Blanchard <hollis@penguinppc.org> writes:

> Now that module support is within reach, this patch implements the Open
> Firmware "enter" command, which allows us to get back to the interactive
> OF prompt after loading a client program (GRUB).

Nice!

> As discussed previously, the GRUB command name is "suspend", and the
> file is in a new commands/ieee1275 directory, as it should work on all
> Open Firmware architectures.

Before this can be checked in, I want to wait until Okuji agrees with
this directory layout.

> I have successfully tested this on my G3. The briQ seems to have an
> unfortunate bug: "enter" works, but running "go" to resume GRUB results
> in GRUB being re-entered from its entry point. I wonder if this bug
> still affects later Codegen releases (i.e the Pegasos)...
>
I can test this and I will let you know.

> +static grub_err_t
> +grub_cmd_suspend (struct grub_arg_list *state, int argc, char **args)
> +{
> +  (void)state;
> +  (void)argc;
> +  (void)args;

Better use an attribute for this.

> +  grub_printf("Run 'go' to resume GRUB.\n");
> +  grub_ieee1275_enter();

Can you add a space before the ()?

Thanks,
Marco