[PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Marek Vasut]

From: Alexander Koch <akoch@initse.com>

Indent SF: just like other boot time messages. Change the original indent:

"
DRAM:  3.5 GiB
Core:  310 devices, 34 uclasses, devicetree: separate
SF: Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
"

to the fixed indent:

"
DRAM:  3.5 GiB
Core:  310 devices, 34 uclasses, devicetree: separate
SF:    Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
    ^^^
"

No functional change.

Signed-off-by: Alexander Koch <akoch@initse.com>
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Alexander Koch <akoch@initse.com>
Cc: David Lechner <dlechner@baylibre.com>
Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Takahiro Kuwano <takahiro.kuwano@infineon.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Vignesh R <vigneshr@ti.com>
Cc: u-boot@lists.denx.de
---
 drivers/mtd/spi/spi-nor-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c
index 937d79af64e..c73f2c7c3f8 100644
--- a/drivers/mtd/spi/spi-nor-core.c
+++ b/drivers/mtd/spi/spi-nor-core.c
@@ -4758,7 +4758,7 @@ int spi_nor_scan(struct spi_nor *nor)
 	nor->sector_size = mtd->erasesize;
 
 #ifndef CONFIG_XPL_BUILD
-	printf("SF: Detected %s with page size ", nor->name);
+	printf("SF:    Detected %s with page size ", nor->name);
 	print_size(nor->page_size, ", erase size ");
 	print_size(nor->erase_size, ", total ");
 	print_size(nor->size, "");
-- 
2.53.0

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

On Fri, Jun 12, 2026 at 12:45:19AM +0200, Marek Vasut wrote:

> From: Alexander Koch <akoch@initse.com>
> 
> Indent SF: just like other boot time messages. Change the original indent:
> 
> "
> DRAM:  3.5 GiB
> Core:  310 devices, 34 uclasses, devicetree: separate
> SF: Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
> "
> 
> to the fixed indent:
> 
> "
> DRAM:  3.5 GiB
> Core:  310 devices, 34 uclasses, devicetree: separate
> SF:    Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
>     ^^^
> "
> 
> No functional change.
> 
> Signed-off-by: Alexander Koch <akoch@initse.com>
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Alexander Koch <akoch@initse.com>
> Cc: David Lechner <dlechner@baylibre.com>
> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Takahiro Kuwano <takahiro.kuwano@infineon.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
> Cc: Vignesh R <vigneshr@ti.com>
> Cc: u-boot@lists.denx.de
> ---

Sorry for the delay on this patch. It breaks the tests which expect the
current spacing:
https://git.u-boot-project.org/u-boot/u-boot/-/jobs/124896#L292

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Stefan Monnier]

> to the fixed indent:
>
> "
> DRAM:  3.5 GiB
> Core:  310 devices, 34 uclasses, devicetree: separate
> SF:    Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
>     ^^^

I'm probably not the targeted audience, but FWIW, I find the meaning of
"SF" non-obvious, so maybe instead of adding spaces, we could use those
3 extra characters to come up with a slightly more
self-explanatory abbreviation?


=== Stefan

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Marek Vasut]

On 10/24/26 5:14 PM, Stefan Monnier wrote:
>> to the fixed indent:
>>
>> "
>> DRAM:  3.5 GiB
>> Core:  310 devices, 34 uclasses, devicetree: separate
>> SF:    Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
>>      ^^^
> 
> I'm probably not the targeted audience, but FWIW, I find the meaning of
> "SF" non-obvious, so maybe instead of adding spaces, we could use those
> 3 extra characters to come up with a slightly more
> self-explanatory abbreviation?
SF is SPI Flash , it is used all over the code base.

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Marek Vasut]

On 10/24/26 4:23 PM, Tom Rini wrote:

Hello Tom,

>> From: Alexander Koch <akoch@initse.com>
>>
>> Indent SF: just like other boot time messages. Change the original indent:
>>
>> "
>> DRAM:  3.5 GiB
>> Core:  310 devices, 34 uclasses, devicetree: separate
>> SF: Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
>> "
>>
>> to the fixed indent:
>>
>> "
>> DRAM:  3.5 GiB
>> Core:  310 devices, 34 uclasses, devicetree: separate
>> SF:    Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total 16 MiB
>>      ^^^
>> "
>>
>> No functional change.
>>
>> Signed-off-by: Alexander Koch <akoch@initse.com>
>> Signed-off-by: Marek Vasut <marex@nabladev.com>
>> ---
>> Cc: Alexander Koch <akoch@initse.com>
>> Cc: David Lechner <dlechner@baylibre.com>
>> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Takahiro Kuwano <takahiro.kuwano@infineon.com>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
>> Cc: Vignesh R <vigneshr@ti.com>
>> Cc: u-boot@lists.denx.de
>> ---
> 
> Sorry for the delay on this patch. It breaks the tests which expect the
> current spacing:
> https://git.u-boot-project.org/u-boot/u-boot/-/jobs/124896#L292
I've sent V2 now with that fixed.

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[E Shattow]

On 10/24/26 11:05, Marek Vasut wrote:
> On 10/24/26 5:14 PM, Stefan Monnier wrote:
>>> to the fixed indent:
>>>
>>> "
>>> DRAM:  3.5 GiB
>>> Core:  310 devices, 34 uclasses, devicetree: separate
>>> SF:    Detected w25q128jw with page size 256 Bytes, erase size 4 KiB,
>>> total 16 MiB
>>>      ^^^
>>
>> I'm probably not the targeted audience, but FWIW, I find the meaning of
>> "SF" non-obvious, so maybe instead of adding spaces, we could use those
>> 3 extra characters to come up with a slightly more
>> self-explanatory abbreviation?
> SF is SPI Flash , it is used all over the code base.

I also find the meaning of "SF" non-obvious, and nothing better comes to
mind to abbreviate it. You cannot get to "sf" command from "spi flash"
or "flash" commands. If the probe message would say "SPI [NOR|NAND]
Flash detected ...." or "SPI: [NOR|NAND] Flash detected ..." it would
have the context needed, else I have to look up a part number or make a
guess what that is about, remembering the first time I was confused
about this. It could be easier, but I don't know if that's better.

The indent change looks okay to me, a few bytes' increase, if there is
no \t tabstop to reduce byte count and get the same effect.

-E

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Stefan Monnier]

E Shattow [2026-10-25 06:29:43] wrote:

> On 10/24/26 11:05, Marek Vasut wrote:
>> On 10/24/26 5:14 PM, Stefan Monnier wrote:
>>>> to the fixed indent:
>>>>
>>>> "
>>>> DRAM:  3.5 GiB
>>>> Core:  310 devices, 34 uclasses, devicetree: separate
>>>> SF:    Detected w25q128jw with page size 256 Bytes, erase size
>>>> 4 KiB, total 16 MiB
>>>>      ^^^
>>>
>>> I'm probably not the targeted audience, but FWIW, I find the meaning of
>>> "SF" non-obvious, so maybe instead of adding spaces, we could use those
>>> 3 extra characters to come up with a slightly more
>>> self-explanatory abbreviation?
>> SF is SPI Flash , it is used all over the code base.

Yes, that's indeed how I figured what it meant, but it would be better
if users could figure that out without having to consult the source code.

> I also find the meaning of "SF" non-obvious, and nothing better comes to
> mind to abbreviate it. You cannot get to "sf" command from "spi flash"
> or "flash" commands. If the probe message would say "SPI [NOR|NAND]
> Flash detected ...." or "SPI: [NOR|NAND] Flash detected ..." it would

How 'bout

    SPI:   16MB flash (w25q128jw) with page size 256 Bytes, erase size 4 KiB


=== Stefan

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[E Shattow]

Hi Stefan,

On 10/25/26 07:10, Stefan Monnier wrote:
> E Shattow [2026-10-25 06:29:43] wrote:
> 
>> On 10/24/26 11:05, Marek Vasut wrote:
>>> On 10/24/26 5:14 PM, Stefan Monnier wrote:
>>>>> to the fixed indent:
>>>>>
>>>>> "
>>>>> DRAM:  3.5 GiB
>>>>> Core:  310 devices, 34 uclasses, devicetree: separate
>>>>> SF:    Detected w25q128jw with page size 256 Bytes, erase size
>>>>> 4 KiB, total 16 MiB
>>>>>      ^^^
>>>>
>>>> I'm probably not the targeted audience, but FWIW, I find the meaning of
>>>> "SF" non-obvious, so maybe instead of adding spaces, we could use those
>>>> 3 extra characters to come up with a slightly more
>>>> self-explanatory abbreviation?
>>> SF is SPI Flash , it is used all over the code base.
> 
> Yes, that's indeed how I figured what it meant, but it would be better
> if users could figure that out without having to consult the source code.
> 
>> I also find the meaning of "SF" non-obvious, and nothing better comes to
>> mind to abbreviate it. You cannot get to "sf" command from "spi flash"
>> or "flash" commands. If the probe message would say "SPI [NOR|NAND]
>> Flash detected ...." or "SPI: [NOR|NAND] Flash detected ..." it would
> 
> How 'bout
> 
>     SPI:   16MB flash (w25q128jw) with page size 256 Bytes, erase size 4 KiB
> 
> 
> === Stefan
> 

If we can spare the bytes then "SF:  SPI Flash 16MB w25q128jw with page
size 256 Bytes, erase size" answers the context concern for me. The name
of the config is SPI_FLASH so doing anything in a different order or to
be clever is not as good to my eye.

'sf' command is only ever used for NOR? Never NAND?

Also don't take this as changes requested from me, I'd just as soon
leave it alone. I'm acknowledging that it's awkward and if you want to
make it better I'll give an opinion on it, but that's it. ;)

-E

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Miquel Raynal]

On 25/10/2026 at 10:10:04 -04, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> E Shattow [2026-10-25 06:29:43] wrote:
>
>> On 10/24/26 11:05, Marek Vasut wrote:
>>> On 10/24/26 5:14 PM, Stefan Monnier wrote:
>>>>> to the fixed indent:
>>>>>
>>>>> "
>>>>> DRAM:  3.5 GiB
>>>>> Core:  310 devices, 34 uclasses, devicetree: separate
>>>>> SF:    Detected w25q128jw with page size 256 Bytes, erase size
>>>>> 4 KiB, total 16 MiB
>>>>>      ^^^
>>>>
>>>> I'm probably not the targeted audience, but FWIW, I find the meaning of
>>>> "SF" non-obvious, so maybe instead of adding spaces, we could use those
>>>> 3 extra characters to come up with a slightly more
>>>> self-explanatory abbreviation?
>>> SF is SPI Flash , it is used all over the code base.
>
> Yes, that's indeed how I figured what it meant, but it would be better
> if users could figure that out without having to consult the source code.
>
>> I also find the meaning of "SF" non-obvious, and nothing better comes to
>> mind to abbreviate it. You cannot get to "sf" command from "spi flash"
>> or "flash" commands. If the probe message would say "SPI [NOR|NAND]
>> Flash detected ...." or "SPI: [NOR|NAND] Flash detected ..." it would

Except sf is only about SPI NORs, not SPI NANDs. The tool has been here
for ages, it is light, but very limited (single chip, spi nor
only). People may use the mtd tool instead, which is much heavier
(requires the mtd layer which is optional) but flash/bus agnostic. All
this to say, I don't know how to make a better shortcut for it, and yes
this acronym is already sparkled all over the place.

     SPINOR:Detected

would fit, but no more space ;)

Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[E Shattow]

On 10/26/26 01:25, Miquel Raynal wrote:
> On 25/10/2026 at 10:10:04 -04, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> E Shattow [2026-10-25 06:29:43] wrote:
>>
>>> On 10/24/26 11:05, Marek Vasut wrote:
>>>> On 10/24/26 5:14 PM, Stefan Monnier wrote:
>>>>>> to the fixed indent:
>>>>>>
>>>>>> "
>>>>>> DRAM:  3.5 GiB
>>>>>> Core:  310 devices, 34 uclasses, devicetree: separate
>>>>>> SF:    Detected w25q128jw with page size 256 Bytes, erase size
>>>>>> 4 KiB, total 16 MiB
>>>>>>      ^^^
>>>>>
>>>>> I'm probably not the targeted audience, but FWIW, I find the meaning of
>>>>> "SF" non-obvious, so maybe instead of adding spaces, we could use those
>>>>> 3 extra characters to come up with a slightly more
>>>>> self-explanatory abbreviation?
>>>> SF is SPI Flash , it is used all over the code base.
>>
>> Yes, that's indeed how I figured what it meant, but it would be better
>> if users could figure that out without having to consult the source code.
>>
>>> I also find the meaning of "SF" non-obvious, and nothing better comes to
>>> mind to abbreviate it. You cannot get to "sf" command from "spi flash"
>>> or "flash" commands. If the probe message would say "SPI [NOR|NAND]
>>> Flash detected ...." or "SPI: [NOR|NAND] Flash detected ..." it would
> 
> Except sf is only about SPI NORs, not SPI NANDs. The tool has been here
> for ages, it is light, but very limited (single chip, spi nor
> only). People may use the mtd tool instead, which is much heavier
> (requires the mtd layer which is optional) but flash/bus agnostic. All
> this to say, I don't know how to make a better shortcut for it, and yes
> this acronym is already sparkled all over the place.
> 
>      SPINOR:Detected
> 
> would fit, but no more space ;)
> 

The word choice of "Detected" is informative, but not very useful when
missing the contextual clue of "what is 'S' in 'SF:' ?"

SF: Detected w25q128jw with page size 256 Bytes, erase size 4 KiB, total
16 MiB

SF:    SPI flash w25q128jw page size 256 Bytes, erase size 4 KiB, total
16 MiB
SF:    w25q128jw SPI flash page size 256 Bytes, erase size 4 KiB, total
16 MiB

SF:    SPI NOR w25q128jw page size 256 Bytes, erase size 4 KiB, total 16 MiB
SF:    SPI NAND w25q128jw page size 256 Bytes, erase size 4 KiB, total
16 MiB

SF:    w25q128jw SPI NOR page size 256 Bytes, erase size 4 KiB, total 16 MiB
SF:    w25q128jw SPI NAND page size 256 Bytes, erase size 4 KiB, total
16 MiB

SF:    w25q128jw page size 256 Bytes, erase size 4 KiB, total 16 MiB SPI NOR
SF:    w25q128jw page size 256 Bytes, erase size 4 KiB, total 16 MiB SPI
NAND

Save a byte and add the context along with the indent you are
suggesting. Leave headroom for dropping "flash" and substituted with
[NOR|NAND] if the command does grow to beyond a single type. Guessing
that "F" in "SF" means something is easier if we are shown what the
meaning of "S" in "SF" is.

-E