* Re: [PATCH net] net: ll_temac: Return actual error from of_get_mac_address()
2026-08-27 1:24 ` [PATCH net] net: ll_temac: Return actual error from of_get_mac_address() Rosen Penev
@ 2026-08-27 1:39 ` Andrew Lunn
2026-08-27 8:46 ` Esben Haabendal
2026-09-01 0:05 ` Jakub Kicinski
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2026-08-27 1:39 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Michal Simek, Esben Haabendal,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
On Wed, Aug 26, 2026 at 06:24:39PM -0700, Rosen Penev wrote:
> When of_get_mac_address() fails, return the actual error code (rc)
> instead of the hardcoded -ENODEV. This preserves the original error
> information, which may be more specific (e.g., -EINVAL, -EPROBE_DEFER)
> and helps callers handle the failure appropriately.
>
> Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ll_temac: Return actual error from of_get_mac_address()
2026-08-27 1:24 ` [PATCH net] net: ll_temac: Return actual error from of_get_mac_address() Rosen Penev
2026-08-27 1:39 ` Andrew Lunn
@ 2026-08-27 8:46 ` Esben Haabendal
2026-09-01 0:05 ` Jakub Kicinski
2 siblings, 0 replies; 4+ messages in thread
From: Esben Haabendal @ 2026-08-27 8:46 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Michal Simek, linux-arm-kernel,
linux-kernel
"Rosen Penev" <rosenp@gmail.com> writes:
> When of_get_mac_address() fails, return the actual error code (rc)
> instead of the hardcoded -ENODEV. This preserves the original error
> information, which may be more specific (e.g., -EINVAL, -EPROBE_DEFER)
> and helps callers handle the failure appropriately.
>
> Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
> index 711ed9c2631b..81ec73e6e4c1 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
> @@ -1581,7 +1581,7 @@ static int temac_probe(struct platform_device *pdev)
> rc = of_get_mac_address(temac_np, addr);
> if (rc) {
> dev_err(&pdev->dev, "could not find MAC address\n");
> - return -ENODEV;
> + return rc;
> }
> temac_init_mac_address(ndev, addr);
> } else if (pdata) {
> --
> 2.55.0
Acked-by: Esben Haabendal <esben@geanix.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ll_temac: Return actual error from of_get_mac_address()
2026-08-27 1:24 ` [PATCH net] net: ll_temac: Return actual error from of_get_mac_address() Rosen Penev
2026-08-27 1:39 ` Andrew Lunn
2026-08-27 8:46 ` Esben Haabendal
@ 2026-09-01 0:05 ` Jakub Kicinski
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2026-09-01 0:05 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Michal Simek, Esben Haabendal,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
On Wed, 26 Aug 2026 18:24:39 -0700 Rosen Penev wrote:
> rc = of_get_mac_address(temac_np, addr);
> if (rc) {
> dev_err(&pdev->dev, "could not find MAC address\n");
dev_err_probe() if you're trying to handle rc == -EPROBE_DEFER
> - return -ENODEV;
> + return rc;
--
pw-bot: cr
^ permalink raw reply [flat|nested] 4+ messages in thread