Re: [PATCH 2/3] docs/devel/tcg-ops: List more vector opcodes

["Alex Bennée" <alex.bennee@linaro.org>]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Few logical and arithmetic vector opcodes are missing, list them.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  docs/devel/tcg-ops.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/docs/devel/tcg-ops.rst b/docs/devel/tcg-ops.rst
> index c417ebe65a8..56c0b0bd3de 100644
> --- a/docs/devel/tcg-ops.rst
> +++ b/docs/devel/tcg-ops.rst
> @@ -816,10 +816,16 @@ specifies the length of the element (if applicable) in log2 8-bit units.
>  
>     * - and_vec *v0*, *v1*, *v2*
>  
> +       nand_vec *v0*, *v1*, *v2*
> +
>         or_vec *v0*, *v1*, *v2*
>  
> +       nor_vec *v0*, *v1*, *v2*
> +
>         xor_vec *v0*, *v1*, *v2*
>  
> +       eqv_vec *v0*, *v1*, *v2*
> +
>         andc_vec *v0*, *v1*, *v2*
>  
>         orc_vec *v0*, *v1*, *v2*
> @@ -852,6 +858,8 @@ specifies the length of the element (if applicable) in log2 8-bit units.
>  
>         sars_vec *v0*, *v1*, *s2*
>  
> +       rotls_vec *v0*, *v1*, *s2*
> +
>       - | Similarly for logical and arithmetic right shift, and left rotate.
>  
>     * - shlv_vec *v0*, *v1*, *v2*

Longer term it would be nice to just auto-generate these from tcg-op.h
and tcg-op-common.h but I guess we would need to see if kdoc can handle
grouping of sets of ops rather than having to exhaustively enumerate
every bitop with comments. 

Anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro