* [PATCH] migration: Fix extra cleanup at postcopy listen
@ 2024-11-25 19:11 Fabiano Rosas
2024-11-25 19:28 ` Peter Xu
0 siblings, 1 reply; 3+ messages in thread
From: Fabiano Rosas @ 2024-11-25 19:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Xu
After fixing the loadvm cleanup race the qemu_loadvm_state_cleanup()
is now being called twice in the postcopy listen thread.
Fixes: 4ce5622908 ("migration/multifd: Fix rb->receivedmap cleanup race")
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/savevm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index f4e4876f72..98821c8120 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2057,7 +2057,6 @@ static void *postcopy_ram_listen_thread(void *opaque)
* got a bad migration state).
*/
migration_incoming_state_destroy();
- qemu_loadvm_state_cleanup();
rcu_unregister_thread();
mis->have_listen_thread = false;
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] migration: Fix extra cleanup at postcopy listen
2024-11-25 19:11 [PATCH] migration: Fix extra cleanup at postcopy listen Fabiano Rosas
@ 2024-11-25 19:28 ` Peter Xu
2024-11-25 19:42 ` Fabiano Rosas
0 siblings, 1 reply; 3+ messages in thread
From: Peter Xu @ 2024-11-25 19:28 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: qemu-devel
On Mon, Nov 25, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote:
> After fixing the loadvm cleanup race the qemu_loadvm_state_cleanup()
> is now being called twice in the postcopy listen thread.
>
> Fixes: 4ce5622908 ("migration/multifd: Fix rb->receivedmap cleanup race")
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
This is so far harmless, right? I think we can still queue this for 9.2,
but I'd just like to double check..
> ---
> migration/savevm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index f4e4876f72..98821c8120 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2057,7 +2057,6 @@ static void *postcopy_ram_listen_thread(void *opaque)
> * got a bad migration state).
> */
> migration_incoming_state_destroy();
> - qemu_loadvm_state_cleanup();
>
> rcu_unregister_thread();
> mis->have_listen_thread = false;
> --
> 2.35.3
>
--
Peter Xu
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] migration: Fix extra cleanup at postcopy listen
2024-11-25 19:28 ` Peter Xu
@ 2024-11-25 19:42 ` Fabiano Rosas
0 siblings, 0 replies; 3+ messages in thread
From: Fabiano Rosas @ 2024-11-25 19:42 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel
Peter Xu <peterx@redhat.com> writes:
> On Mon, Nov 25, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote:
>> After fixing the loadvm cleanup race the qemu_loadvm_state_cleanup()
>> is now being called twice in the postcopy listen thread.
>>
>> Fixes: 4ce5622908 ("migration/multifd: Fix rb->receivedmap cleanup race")
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>
> This is so far harmless, right? I think we can still queue this for 9.2,
> but I'd just like to double check..
>
I believe so, yes.
>> ---
>> migration/savevm.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/migration/savevm.c b/migration/savevm.c
>> index f4e4876f72..98821c8120 100644
>> --- a/migration/savevm.c
>> +++ b/migration/savevm.c
>> @@ -2057,7 +2057,6 @@ static void *postcopy_ram_listen_thread(void *opaque)
>> * got a bad migration state).
>> */
>> migration_incoming_state_destroy();
>> - qemu_loadvm_state_cleanup();
>>
>> rcu_unregister_thread();
>> mis->have_listen_thread = false;
>> --
>> 2.35.3
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-25 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-25 19:11 [PATCH] migration: Fix extra cleanup at postcopy listen Fabiano Rosas
2024-11-25 19:28 ` Peter Xu
2024-11-25 19:42 ` Fabiano Rosas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.