All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Lukasz Majewski <lukma@denx.de>
Cc: Tom Rini <trini@konsulko.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Subject: Re: [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies
Date: Tue, 01 Oct 2024 11:01:41 +0200	[thread overview]
Message-ID: <87ikucci2y.fsf@baylibre.com> (raw)
In-Reply-To: <20240921092050.9260-1-heinrich.schuchardt@canonical.com>

Hi Heinrich,

Thank you for the patch.

On sam., sept. 21, 2024 at 11:20, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:

> CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET.
> It is sufficient to depend on the prior.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  cmd/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 4ccb0cef390..02b2569e713 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1685,9 +1685,8 @@ config CMD_ROCKUSB
>  
>  config CMD_USB_MASS_STORAGE
>  	bool "UMS usb mass storage"
> -	depends on USB_GADGET_DOWNLOAD
> +	depends on BLK && USB_GADGET_DOWNLOAD
>  	select USB_FUNCTION_MASS_STORAGE
> -	depends on BLK && USB_GADGET
>  	help
>  	  Enables the command "ums" and the USB mass storage support to the
>  	  export a block device: U-Boot, the USB device, acts as a simple
> -- 
> 2.45.2

  reply	other threads:[~2024-10-01  9:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-21  9:20 [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies Heinrich Schuchardt
2024-10-01  9:01 ` Mattijs Korpershoek [this message]
2024-10-01 12:24 ` Caleb Connolly
2024-10-03  8:02 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikucci2y.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=caleb.connolly@linaro.org \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=lukma@denx.de \
    --cc=neil.armstrong@linaro.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.