* [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies
@ 2024-09-21 9:20 Heinrich Schuchardt
2024-10-01 9:01 ` Mattijs Korpershoek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2024-09-21 9:20 UTC (permalink / raw)
To: Lukasz Majewski
Cc: Mattijs Korpershoek, Tom Rini, Neil Armstrong, Caleb Connolly,
Simon Glass, u-boot, Heinrich Schuchardt
CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET.
It is sufficient to depend on the prior.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
cmd/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 4ccb0cef390..02b2569e713 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1685,9 +1685,8 @@ config CMD_ROCKUSB
config CMD_USB_MASS_STORAGE
bool "UMS usb mass storage"
- depends on USB_GADGET_DOWNLOAD
+ depends on BLK && USB_GADGET_DOWNLOAD
select USB_FUNCTION_MASS_STORAGE
- depends on BLK && USB_GADGET
help
Enables the command "ums" and the USB mass storage support to the
export a block device: U-Boot, the USB device, acts as a simple
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies
2024-09-21 9:20 [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies Heinrich Schuchardt
@ 2024-10-01 9:01 ` Mattijs Korpershoek
2024-10-01 12:24 ` Caleb Connolly
2024-10-03 8:02 ` Mattijs Korpershoek
2 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2024-10-01 9:01 UTC (permalink / raw)
To: Heinrich Schuchardt, Lukasz Majewski
Cc: Tom Rini, Neil Armstrong, Caleb Connolly, Simon Glass, u-boot,
Heinrich Schuchardt
Hi Heinrich,
Thank you for the patch.
On sam., sept. 21, 2024 at 11:20, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
> CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET.
> It is sufficient to depend on the prior.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> cmd/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 4ccb0cef390..02b2569e713 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1685,9 +1685,8 @@ config CMD_ROCKUSB
>
> config CMD_USB_MASS_STORAGE
> bool "UMS usb mass storage"
> - depends on USB_GADGET_DOWNLOAD
> + depends on BLK && USB_GADGET_DOWNLOAD
> select USB_FUNCTION_MASS_STORAGE
> - depends on BLK && USB_GADGET
> help
> Enables the command "ums" and the USB mass storage support to the
> export a block device: U-Boot, the USB device, acts as a simple
> --
> 2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies
2024-09-21 9:20 [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies Heinrich Schuchardt
2024-10-01 9:01 ` Mattijs Korpershoek
@ 2024-10-01 12:24 ` Caleb Connolly
2024-10-03 8:02 ` Mattijs Korpershoek
2 siblings, 0 replies; 4+ messages in thread
From: Caleb Connolly @ 2024-10-01 12:24 UTC (permalink / raw)
To: Heinrich Schuchardt, Lukasz Majewski
Cc: Mattijs Korpershoek, Tom Rini, Neil Armstrong, Simon Glass,
u-boot
On 21/09/2024 11:20, Heinrich Schuchardt wrote:
> CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET.
> It is sufficient to depend on the prior.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> cmd/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 4ccb0cef390..02b2569e713 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1685,9 +1685,8 @@ config CMD_ROCKUSB
>
> config CMD_USB_MASS_STORAGE
> bool "UMS usb mass storage"
> - depends on USB_GADGET_DOWNLOAD
> + depends on BLK && USB_GADGET_DOWNLOAD
> select USB_FUNCTION_MASS_STORAGE
> - depends on BLK && USB_GADGET
> help
> Enables the command "ums" and the USB mass storage support to the
> export a block device: U-Boot, the USB device, acts as a simple
--
// Caleb (they/them)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies
2024-09-21 9:20 [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies Heinrich Schuchardt
2024-10-01 9:01 ` Mattijs Korpershoek
2024-10-01 12:24 ` Caleb Connolly
@ 2024-10-03 8:02 ` Mattijs Korpershoek
2 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2024-10-03 8:02 UTC (permalink / raw)
To: Lukasz Majewski, Heinrich Schuchardt
Cc: Tom Rini, Neil Armstrong, Caleb Connolly, Simon Glass, u-boot
Hi,
On Sat, 21 Sep 2024 11:20:50 +0200, Heinrich Schuchardt wrote:
> CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET.
> It is sufficient to depend on the prior.
>
>
Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu-next)
[1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/c74758ccc091402b558b9aa7eaf1c50171d2f49f
--
Mattijs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-03 8:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-21 9:20 [PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies Heinrich Schuchardt
2024-10-01 9:01 ` Mattijs Korpershoek
2024-10-01 12:24 ` Caleb Connolly
2024-10-03 8:02 ` Mattijs Korpershoek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.