From: Michael Ellerman <mpe@ellerman.id.au>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] powerpc/xive: convert to of_property_for_each_u32_new()
Date: Wed, 03 Jul 2024 21:36:47 +1000 [thread overview]
Message-ID: <87ikxmk8q8.fsf@mail.lhotse> (raw)
In-Reply-To: <20240703-of_property_for_each_u32-v1-19-42c1fc0b82aa@bootlin.com>
Luca Ceresoli <luca.ceresoli@bootlin.com> writes:
> Simplify code using of_property_for_each_u32_new() as the two additional
> parameters in of_property_for_each_u32() are not used here.
>
> In this case only the 'prop' variable can be removed and not 'reg',
> because 'reg' is used in _previous_ lines of the same function. There
> is no side effect because the of_property_for_each_u32() macro being
> removed would anyway write 'reg' bwfore reading its value, and 'reg'
> is not used in _following_ lines.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> arch/powerpc/sysdev/xive/spapr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 19/20] powerpc/xive: convert to of_property_for_each_u32_new()
Date: Wed, 03 Jul 2024 21:36:47 +1000 [thread overview]
Message-ID: <87ikxmk8q8.fsf@mail.lhotse> (raw)
In-Reply-To: <20240703-of_property_for_each_u32-v1-19-42c1fc0b82aa@bootlin.com>
Luca Ceresoli <luca.ceresoli@bootlin.com> writes:
> Simplify code using of_property_for_each_u32_new() as the two additional
> parameters in of_property_for_each_u32() are not used here.
>
> In this case only the 'prop' variable can be removed and not 'reg',
> because 'reg' is used in _previous_ lines of the same function. There
> is no side effect because the of_property_for_each_u32() macro being
> removed would anyway write 'reg' bwfore reading its value, and 'reg'
> is not used in _following_ lines.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> arch/powerpc/sysdev/xive/spapr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
next prev parent reply other threads:[~2024-07-03 11:37 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 10:36 [PATCH 00/20] Simplify of_property_for_each_u32() Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 01/20] of: add of_property_for_each_u32_new() Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 02/20] clk: convert to of_property_for_each_u32_new() Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 03/20] clk: qcom: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 04/20] clk: sunxi: clk-simple-gates: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 12:21 ` Andre Przywara
2024-07-03 12:21 ` Andre Przywara
2024-07-03 12:21 ` Andre Przywara
2024-07-03 10:36 ` [PATCH 05/20] clk: sunxi: clk-sun8i-bus-gates: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 12:19 ` Andre Przywara
2024-07-03 12:19 ` Andre Przywara
2024-07-03 12:19 ` Andre Przywara
2024-07-03 10:36 ` [PATCH 06/20] clocksource/drivers/samsung_pwm: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 07/20] bus: ti-sysc: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 08/20] lk: clk-conf: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 09/20] gpio: brcmstb: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 11:33 ` Bartosz Golaszewski
2024-07-03 11:33 ` Bartosz Golaszewski
2024-07-03 11:33 ` Bartosz Golaszewski
2024-07-03 10:36 ` [PATCH 10/20] pinctrl: s32cc: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 11/20] irqchip/atmel-aic: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 13:09 ` Nicolas Ferre
2024-07-03 13:09 ` Nicolas Ferre
2024-07-03 13:09 ` Nicolas Ferre
2024-07-03 10:36 ` [PATCH 12/20] iio: adc: ti_am335x_adc: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 15:34 ` Jonathan Cameron
2024-07-03 15:34 ` Jonathan Cameron
2024-07-03 15:34 ` Jonathan Cameron
2024-07-03 10:36 ` [PATCH 13/20] pwm: samsung: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 21:23 ` Uwe Kleine-König
2024-07-03 21:23 ` Uwe Kleine-König
2024-07-03 21:23 ` Uwe Kleine-König
2024-07-03 10:36 ` [PATCH 14/20] tty: sysrq: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` [PATCH 15/20] usb: usb251xb: " Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-03 10:36 ` Luca Ceresoli
2024-07-08 7:45 ` Richard Leitner
2024-07-08 7:45 ` Richard Leitner
2024-07-08 7:45 ` Richard Leitner
2024-07-03 10:37 ` [PATCH 16/20] mfd: ti_am335x_tscadc: " Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 10:37 ` [PATCH 17/20] ASoC: arizona: " Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 11:31 ` Richard Fitzgerald
2024-07-03 11:31 ` Richard Fitzgerald
2024-07-03 11:31 ` Richard Fitzgerald
2024-07-03 12:18 ` Mark Brown
2024-07-03 12:18 ` Mark Brown
2024-07-03 12:18 ` Mark Brown
2024-07-03 10:37 ` [PATCH 18/20] powerpc/xive: " Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 10:37 ` [PATCH 19/20] " Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 11:36 ` Michael Ellerman [this message]
2024-07-03 11:36 ` Michael Ellerman
2024-07-03 10:37 ` [PATCH 20/20] of: deprecate and rename of_property_for_each_u32() Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 10:37 ` Luca Ceresoli
2024-07-03 18:01 ` Rob Herring
2024-07-03 18:01 ` Rob Herring
2024-07-03 18:01 ` Rob Herring
2024-07-04 21:33 ` Luca Ceresoli
2024-07-04 21:33 ` Luca Ceresoli
2024-07-04 21:33 ` Luca Ceresoli
2024-07-03 18:07 ` [PATCH 00/20] Simplify of_property_for_each_u32() Rob Herring
2024-07-03 18:07 ` Rob Herring
2024-07-03 18:07 ` Rob Herring
2024-07-04 21:31 ` Luca Ceresoli
2024-07-04 21:31 ` Luca Ceresoli
2024-07-04 21:31 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikxmk8q8.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luca.ceresoli@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.