All of lore.kernel.org
 help / color / mirror / Atom feed
From: Esben Haabendal <esben@geanix.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,  linux-serial@vger.kernel.org,
	imx@lists.linux.dev,  linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] serial: imx: Introduce timeout when waiting on transmitter empty
Date: Thu, 11 Apr 2024 14:18:07 +0200	[thread overview]
Message-ID: <87il0o6qkg.fsf@geanix.com> (raw)
In-Reply-To: <2024041122-transfer-diffuser-781a@gregkh> (Greg Kroah-Hartman's message of "Thu, 11 Apr 2024 14:06:50 +0200")

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Wed, Apr 10, 2024 at 09:18:32AM +0200, Esben Haabendal wrote:
>> By waiting at most 1 second for USR2_TXDC to be set, we avoid a potential
>> deadlock.
>> 
>> In case of the timeout, there is not much we can do, so we simply ignore
>> the transmitter state and optimistically try to continue.
>> 
>> v2:
>> - Fixed commit message typo
>> - Remove reference to patch series it originated from. This is a
>>   stand-alone patch
>
> The "v2:" stuff needs to go below the --- line, so it doesn't show up in
> the kernel changelog.  The kernel documentation should describe this,
> right?

Right. It is described in Documentation/process/submitting-patches.rst.
Sorry about that.

> Please fix up and send a v3.

On its way.

/Esben

WARNING: multiple messages have this Message-ID (diff)
From: Esben Haabendal <esben@geanix.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,  linux-serial@vger.kernel.org,
	imx@lists.linux.dev,  linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] serial: imx: Introduce timeout when waiting on transmitter empty
Date: Thu, 11 Apr 2024 14:18:07 +0200	[thread overview]
Message-ID: <87il0o6qkg.fsf@geanix.com> (raw)
In-Reply-To: <2024041122-transfer-diffuser-781a@gregkh> (Greg Kroah-Hartman's message of "Thu, 11 Apr 2024 14:06:50 +0200")

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Wed, Apr 10, 2024 at 09:18:32AM +0200, Esben Haabendal wrote:
>> By waiting at most 1 second for USR2_TXDC to be set, we avoid a potential
>> deadlock.
>> 
>> In case of the timeout, there is not much we can do, so we simply ignore
>> the transmitter state and optimistically try to continue.
>> 
>> v2:
>> - Fixed commit message typo
>> - Remove reference to patch series it originated from. This is a
>>   stand-alone patch
>
> The "v2:" stuff needs to go below the --- line, so it doesn't show up in
> the kernel changelog.  The kernel documentation should describe this,
> right?

Right. It is described in Documentation/process/submitting-patches.rst.
Sorry about that.

> Please fix up and send a v3.

On its way.

/Esben

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-04-11 12:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05  9:25 [PATCH 1/2] serial: imx: Introduce timeout when waiting on transmitter empty Esben Haabendal
2024-04-05  9:25 ` Esben Haabendal
2024-04-05  9:49 ` Marc Kleine-Budde
2024-04-05  9:49   ` Marc Kleine-Budde
2024-04-05 17:22   ` Esben Haabendal
2024-04-05 17:22     ` Esben Haabendal
2024-04-05 17:33     ` Marc Kleine-Budde
2024-04-05 17:33       ` Marc Kleine-Budde
2024-04-08  8:57       ` Esben Haabendal
2024-04-08  8:57         ` Esben Haabendal
2024-04-05 17:38 ` Fabio Estevam
2024-04-05 17:38   ` Fabio Estevam
2024-04-05 19:05   ` Sergey Organov
2024-04-05 19:05     ` Sergey Organov
2024-04-08  8:56   ` Esben Haabendal
2024-04-08  8:56     ` Esben Haabendal
2024-04-10  7:18 ` [PATCH v2] " Esben Haabendal
2024-04-10  7:18   ` Esben Haabendal
2024-04-11 12:06   ` Greg Kroah-Hartman
2024-04-11 12:06     ` Greg Kroah-Hartman
2024-04-11 12:18     ` Esben Haabendal [this message]
2024-04-11 12:18       ` Esben Haabendal
2024-04-11 12:19   ` [PATCH v3] " Esben Haabendal
2024-04-11 12:19     ` Esben Haabendal
2024-05-02  9:14     ` Esben Haabendal
2024-05-02  9:14       ` Esben Haabendal
2024-05-04 16:03       ` Greg Kroah-Hartman
2024-05-04 16:03         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il0o6qkg.fsf@geanix.com \
    --to=esben@geanix.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.