From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] m48t59-test: remove shadowed variables and cleanup
Date: Tue, 26 Sep 2023 14:45:44 +0200 [thread overview]
Message-ID: <87il7xrtl3.fsf@pond.sub.org> (raw)
In-Reply-To: <18979284-cb15-4122-bcde-6aecb9a2134a@redhat.com> (Thomas Huth's message of "Mon, 25 Sep 2023 17:09:13 +0200")
Thomas Huth <thuth@redhat.com> writes:
> On 25/09/2023 16.47, Paolo Bonzini wrote:
>> Rename the variable "s" and, while at it, avoid the chance of an overflow in the
>> computation of ABS(t - s).
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> tests/qtest/m48t59-test.c | 17 ++++++++++-------
>> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> I've got a patch for this in my pull request from today already:
>
> https://lore.kernel.org/qemu-devel/20230925090100.45632-4-thuth@redhat.com
Commit 926bef1d82bb9eb7a752aa128d9e70b808906243.
Paolo's patch still applies, and "avoid the chance of an overflow in the
computation of ABS(t - s)" makes me think we still want it. The commit
message needs a tweak, though, since the patch no longer removes
shadowed variables.
prev parent reply other threads:[~2023-09-26 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 14:47 [PATCH] m48t59-test: remove shadowed variables and cleanup Paolo Bonzini
2023-09-25 15:09 ` Thomas Huth
2023-09-26 12:45 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il7xrtl3.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.