From: Marc Zyngier <maz@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Sumit Garg <sumit.garg@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-arm-kernel@lists.infradead.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
Chen-Yu Tsai <wens@csie.org>,
Tomohiro Misono <misono.tomohiro@fujitsu.com>,
Peter Zijlstra <peterz@infradead.org>,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
Stephane Eranian <eranian@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
kgdb-bugreport@lists.sourceforge.net,
Stephen Boyd <swboyd@chromium.org>,
linux-perf-users@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
ito-yuichi@fujitsu.com, Chen-Yu Tsai <wenst@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs
Date: Tue, 12 Sep 2023 13:43:44 +0100 [thread overview]
Message-ID: <87il8f4l4v.wl-maz@kernel.org> (raw)
In-Reply-To: <20230906090246.v13.1.I1223c11c88937bd0cbd9b086d4ef216985797302@changeid>
On Wed, 06 Sep 2023 17:02:56 +0100,
Douglas Anderson <dianders@chromium.org> wrote:
>
> As of commit 6abbd6988971 ("irqchip/gic, gic-v3: Make SGIs use
> handle_percpu_devid_irq()") SGIs are treated the same as PPIs/EPPIs
> and use handle_percpu_devid_irq() by default. Unfortunately,
> handle_percpu_devid_irq() isn't NMI safe, and so to run in an NMI
> context those should use handle_percpu_devid_fasteoi_nmi().
>
> In order to accomplish this, we just have to make room for SGIs in the
> array of refcounts that keeps track of which interrupts are set as
> NMI. We also rename the array and create a new indexing scheme that
> accounts for SGIs.
>
> Also, enable NMI support prior to gic_smp_init() as allocation of SGIs
> as IRQs/NMIs happen as part of this routine.
>
> Co-developed-by: Sumit Garg <sumit.garg@linaro.org>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Sumit Garg <sumit.garg@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-arm-kernel@lists.infradead.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
Chen-Yu Tsai <wens@csie.org>,
Tomohiro Misono <misono.tomohiro@fujitsu.com>,
Peter Zijlstra <peterz@infradead.org>,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
Stephane Eranian <eranian@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
kgdb-bugreport@lists.sourceforge.net,
Stephen Boyd <swboyd@chromium.org>,
linux-perf-users@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
ito-yuichi@fujitsu.com, Chen-Yu Tsai <wenst@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs
Date: Tue, 12 Sep 2023 13:43:44 +0100 [thread overview]
Message-ID: <87il8f4l4v.wl-maz@kernel.org> (raw)
In-Reply-To: <20230906090246.v13.1.I1223c11c88937bd0cbd9b086d4ef216985797302@changeid>
On Wed, 06 Sep 2023 17:02:56 +0100,
Douglas Anderson <dianders@chromium.org> wrote:
>
> As of commit 6abbd6988971 ("irqchip/gic, gic-v3: Make SGIs use
> handle_percpu_devid_irq()") SGIs are treated the same as PPIs/EPPIs
> and use handle_percpu_devid_irq() by default. Unfortunately,
> handle_percpu_devid_irq() isn't NMI safe, and so to run in an NMI
> context those should use handle_percpu_devid_fasteoi_nmi().
>
> In order to accomplish this, we just have to make room for SGIs in the
> array of refcounts that keeps track of which interrupts are set as
> NMI. We also rename the array and create a new indexing scheme that
> accounts for SGIs.
>
> Also, enable NMI support prior to gic_smp_init() as allocation of SGIs
> as IRQs/NMIs happen as part of this routine.
>
> Co-developed-by: Sumit Garg <sumit.garg@linaro.org>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-12 12:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 16:02 [PATCH v13 0/7] arm64: Add IPI for backtraces / kgdb; try to use NMI for some IPIs Douglas Anderson
2023-09-06 16:02 ` Douglas Anderson
2023-09-06 16:02 ` [PATCH v13 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs Douglas Anderson
2023-09-06 16:02 ` Douglas Anderson
2023-09-12 12:43 ` Marc Zyngier [this message]
2023-09-12 12:43 ` Marc Zyngier
2023-09-06 16:02 ` [PATCH v13 2/7] arm64: idle: Tag the arm64 idle functions as __cpuidle Douglas Anderson
2023-09-06 16:02 ` Douglas Anderson
2023-09-06 16:02 ` [PATCH v13 3/7] arm64: smp: Remove dedicated wakeup IPI Douglas Anderson
2023-09-06 16:02 ` Douglas Anderson
2023-09-26 0:39 ` Doug Anderson
2023-09-26 0:39 ` Doug Anderson
2023-10-02 16:48 ` Doug Anderson
2023-10-02 16:48 ` Doug Anderson
2023-09-06 16:02 ` [PATCH v13 4/7] arm64: smp: Add arch support for backtrace using pseudo-NMI Douglas Anderson
2023-09-06 16:02 ` Douglas Anderson
2023-09-06 16:03 ` [PATCH v13 5/7] arm64: smp: IPI_CPU_STOP and IPI_CPU_CRASH_STOP should try for NMI Douglas Anderson
2023-09-06 16:03 ` Douglas Anderson
2023-09-06 16:03 ` [PATCH v13 6/7] arm64: kgdb: Implement kgdb_roundup_cpus() to enable pseudo-NMI roundup Douglas Anderson
2023-09-06 16:03 ` Douglas Anderson
2023-09-06 16:03 ` [PATCH v13 7/7] arm64: smp: Mark IPI globals as __ro_after_init Douglas Anderson
2023-09-06 16:03 ` Douglas Anderson
2023-09-06 21:45 ` Stephen Boyd
2023-09-06 21:45 ` Stephen Boyd
2023-09-25 17:10 ` [PATCH v13 0/7] arm64: Add IPI for backtraces / kgdb; try to use NMI for some IPIs Catalin Marinas
2023-09-25 17:10 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il8f4l4v.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=eranian@google.com \
--cc=ito-yuichi@fujitsu.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=misono.tomohiro@fujitsu.com \
--cc=msys.mizuma@gmail.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
--cc=wenst@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.