* [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT
@ 2023-09-06 20:47 ` Javier Carrasco
0 siblings, 0 replies; 6+ messages in thread
From: Javier Carrasco @ 2023-09-06 20:47 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter
Cc: Javier Carrasco, Randy Dunlap, linux-kernel, dri-devel
The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
properly documented by moving the description out of the enum to the
member description list to get rid of an additional warning and improve
documentation clarity.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
---
Changes in v2:
- Remove applied changes in linux-next (supported_colorspaces
documentation)
- Link to v1: https://lore.kernel.org/r/20230906-topic-drm_connector_doc-v1-1-f4ce7ad0150c@gmail.com
---
include/drm/drm_connector.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index d300fde6c1a4..18cf46e3478b 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
* ITU-R BT.601 colorimetry format
* The DP spec does not say whether this is the 525 or the 625
* line version.
+ * @DRM_MODE_COLORIMETRY_COUNT:
+ * Not a valid value; merely used four counting
*/
enum drm_colorspace {
/* For Default case, driver will set the colorspace */
@@ -522,7 +524,6 @@ enum drm_colorspace {
DRM_MODE_COLORIMETRY_RGB_WIDE_FIXED = 13,
DRM_MODE_COLORIMETRY_RGB_WIDE_FLOAT = 14,
DRM_MODE_COLORIMETRY_BT601_YCC = 15,
- /* not a valid value; merely used for counting */
DRM_MODE_COLORIMETRY_COUNT
};
---
base-commit: 65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4
change-id: 20230906-topic-drm_connector_doc-42dae3ba43c6
Best regards,
--
Javier Carrasco <javier.carrasco.cruz@gmail.com>
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT
@ 2023-09-06 20:47 ` Javier Carrasco
0 siblings, 0 replies; 6+ messages in thread
From: Javier Carrasco @ 2023-09-06 20:47 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter
Cc: dri-devel, linux-kernel, Javier Carrasco, Randy Dunlap
The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
properly documented by moving the description out of the enum to the
member description list to get rid of an additional warning and improve
documentation clarity.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
---
Changes in v2:
- Remove applied changes in linux-next (supported_colorspaces
documentation)
- Link to v1: https://lore.kernel.org/r/20230906-topic-drm_connector_doc-v1-1-f4ce7ad0150c@gmail.com
---
include/drm/drm_connector.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index d300fde6c1a4..18cf46e3478b 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
* ITU-R BT.601 colorimetry format
* The DP spec does not say whether this is the 525 or the 625
* line version.
+ * @DRM_MODE_COLORIMETRY_COUNT:
+ * Not a valid value; merely used four counting
*/
enum drm_colorspace {
/* For Default case, driver will set the colorspace */
@@ -522,7 +524,6 @@ enum drm_colorspace {
DRM_MODE_COLORIMETRY_RGB_WIDE_FIXED = 13,
DRM_MODE_COLORIMETRY_RGB_WIDE_FLOAT = 14,
DRM_MODE_COLORIMETRY_BT601_YCC = 15,
- /* not a valid value; merely used for counting */
DRM_MODE_COLORIMETRY_COUNT
};
---
base-commit: 65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4
change-id: 20230906-topic-drm_connector_doc-42dae3ba43c6
Best regards,
--
Javier Carrasco <javier.carrasco.cruz@gmail.com>
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: (subset) [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT
2023-09-06 20:47 ` Javier Carrasco
@ 2023-09-07 14:32 ` Maxime Ripard
-1 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2023-09-07 14:32 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Daniel Vetter,
Javier Carrasco
Cc: Randy Dunlap, linux-kernel, dri-devel
On Wed, 06 Sep 2023 22:47:38 +0200, Javier Carrasco wrote:
> The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
> properly documented by moving the description out of the enum to the
> member description list to get rid of an additional warning and improve
> documentation clarity.
>
>
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT
@ 2023-09-07 14:32 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2023-09-07 14:32 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Daniel Vetter,
Javier Carrasco
Cc: dri-devel, linux-kernel, Randy Dunlap
On Wed, 06 Sep 2023 22:47:38 +0200, Javier Carrasco wrote:
> The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
> properly documented by moving the description out of the enum to the
> member description list to get rid of an additional warning and improve
> documentation clarity.
>
>
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT
2023-09-07 14:32 ` Maxime Ripard
(?)
@ 2023-09-11 10:23 ` Jani Nikula
2023-09-11 15:16 ` Randy Dunlap
-1 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2023-09-11 10:23 UTC (permalink / raw)
To: Maxime Ripard, Maarten Lankhorst, Thomas Zimmermann, David Airlie,
Daniel Vetter, Javier Carrasco
Cc: Randy Dunlap, linux-kernel, dri-devel
On Thu, 07 Sep 2023, Maxime Ripard <mripard@kernel.org> wrote:
> On Wed, 06 Sep 2023 22:47:38 +0200, Javier Carrasco wrote:
>> The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
>> properly documented by moving the description out of the enum to the
>> member description list to get rid of an additional warning and improve
>> documentation clarity.
>>
>>
>
> Applied to drm/drm-misc (drm-misc-next).
After the fact, but adding /* private: */ would've been an alternative
approach. I think support for that for enums should be there.
Anyway, just for future reference, the merged patch is fine.
BR,
Jani.
>
> Thanks!
> Maxime
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT
2023-09-11 10:23 ` Jani Nikula
@ 2023-09-11 15:16 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2023-09-11 15:16 UTC (permalink / raw)
To: Jani Nikula, Maxime Ripard, Maarten Lankhorst, Thomas Zimmermann,
David Airlie, Daniel Vetter, Javier Carrasco
Cc: linux-kernel, dri-devel
On 9/11/23 03:23, Jani Nikula wrote:
> On Thu, 07 Sep 2023, Maxime Ripard <mripard@kernel.org> wrote:
>> On Wed, 06 Sep 2023 22:47:38 +0200, Javier Carrasco wrote:
>>> The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
>>> properly documented by moving the description out of the enum to the
>>> member description list to get rid of an additional warning and improve
>>> documentation clarity.
>>>
>>>
>>
>> Applied to drm/drm-misc (drm-misc-next).
>
> After the fact, but adding /* private: */ would've been an alternative
> approach. I think support for that for enums should be there.
Yes, that was the first patch that I sent....
but nobody picked it up.
>
> Anyway, just for future reference, the merged patch is fine.
>
> BR,
> Jani.
>
>>
>> Thanks!
>> Maxime
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-11 15:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-06 20:47 [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT Javier Carrasco
2023-09-06 20:47 ` Javier Carrasco
2023-09-07 14:32 ` (subset) " Maxime Ripard
2023-09-07 14:32 ` Maxime Ripard
2023-09-11 10:23 ` Jani Nikula
2023-09-11 15:16 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.