All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ruliang Lin <u202112092@hust.edu.cn>
Cc: Daniel Mack <zonque@gmail.com>, Takashi Iwai <tiwai@suse.com>,
	Karsten Wiese <fzu@wemgehoertderstaat.de>,
	hust-os-kernel-patches@googlegroups.com,
	Dongliang Mu <dzm91@hust.edu.cn>, Daniel Mack <daniel@caiaq.org>,
	Jaroslav Kysela <perex@suse.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: caiaq: input: Add error handling for unsupported input methods in `snd_usb_caiaq_input_init`
Date: Thu, 04 May 2023 09:51:15 +0200	[thread overview]
Message-ID: <87ild8mt58.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230504065054.3309-1-u202112092@hust.edu.cn>

On Thu, 04 May 2023 08:50:53 +0200,
Ruliang Lin wrote:
> 
> Smatch complains that:
> snd_usb_caiaq_input_init() warn: missing error code 'ret'
> 
> This patch adds a new case to handle the situation where the 
> device does not support any input methods in the 
> `snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code 
> to indicate that no input methods are supported on the device.
> 
> Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support")
> Signed-off-by: Ruliang Lin <u202112092@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> The issue is found by static analyzer. The patched code has passed
> Smatch checker, but remains untested on real device.

Thanks, applied.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Ruliang Lin <u202112092@hust.edu.cn>
Cc: Daniel Mack <zonque@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Karsten Wiese <fzu@wemgehoertderstaat.de>,
	hust-os-kernel-patches@googlegroups.com,
	Dongliang Mu <dzm91@hust.edu.cn>, Daniel Mack <daniel@caiaq.org>,
	Jaroslav Kysela <perex@suse.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: caiaq: input: Add error handling for unsupported input methods in `snd_usb_caiaq_input_init`
Date: Thu, 04 May 2023 09:51:15 +0200	[thread overview]
Message-ID: <87ild8mt58.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230504065054.3309-1-u202112092@hust.edu.cn>

On Thu, 04 May 2023 08:50:53 +0200,
Ruliang Lin wrote:
> 
> Smatch complains that:
> snd_usb_caiaq_input_init() warn: missing error code 'ret'
> 
> This patch adds a new case to handle the situation where the 
> device does not support any input methods in the 
> `snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code 
> to indicate that no input methods are supported on the device.
> 
> Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support")
> Signed-off-by: Ruliang Lin <u202112092@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> The issue is found by static analyzer. The patched code has passed
> Smatch checker, but remains untested on real device.

Thanks, applied.


Takashi

  parent reply	other threads:[~2023-05-04  7:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04  6:50 [PATCH] sound: caiaq: input: Add error handling for unsupported input methods in `snd_usb_caiaq_input_init` Ruliang Lin
2023-05-04  6:54 ` Daniel Mack
2023-05-04  7:51 ` Takashi Iwai [this message]
2023-05-04  7:51   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ild8mt58.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@caiaq.org \
    --cc=dzm91@hust.edu.cn \
    --cc=fzu@wemgehoertderstaat.de \
    --cc=hust-os-kernel-patches@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=tiwai@suse.com \
    --cc=u202112092@hust.edu.cn \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.