From: Takashi Iwai <tiwai@suse.de>
To: Jason Montleon <jmontleo@redhat.com>
Cc: oder_chiou@realtek.com, cezary.rojewski@intel.com,
ckeepax@opensource.cirrus.com, regressions@lists.linux.dev,
tiwai@suse.com, alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com, broonie@kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: rt5514: fix legacy dai naming
Date: Thu, 03 Nov 2022 14:24:13 +0100 [thread overview]
Message-ID: <87iljwmarm.wl-tiwai@suse.de> (raw)
In-Reply-To: <87k04cmavy.wl-tiwai@suse.de>
On Thu, 03 Nov 2022 14:21:37 +0100,
Takashi Iwai wrote:
>
> On Thu, 03 Nov 2022 14:11:43 +0100,
> Jason Montleon wrote:
> >
> > Starting with 6.0-rc1 these messages are logged and the sound card
> > is unavailable. Adding legacy_dai_naming to the rt5514-spi causes
> > it to function properly again.
> >
> > [ 16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI
> > spi-PRP0001:00 not registered
> > [ 16.928561] platform kbl_r5514_5663_max: deferred probe pending
>
> Please avoid hanging on the existing thread if you resubmit a new
> patch set.
>
> Also, more importantly, your Signed-off-by tag is missing. It's a
> legal requirement.
>
> At the next time, run scripts/checkpatch.pl before the submission.
> It'll catch such errors.
Also, it's better to have a few more things in the patches:
- Fixes tag indicating the buggy commit to be fixed
- Link (or BugLink tag) to pointing to the kernel bugzilla URL
- Cc-to-stable tag, to assure the fix going to 6.0.y stable tree
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Jason Montleon <jmontleo@redhat.com>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
cezary.rojewski@intel.com, ckeepax@opensource.cirrus.com,
oder_chiou@realtek.com, regressions@lists.linux.dev,
tiwai@suse.com
Subject: Re: [PATCH v2 1/2] ASoC: rt5514: fix legacy dai naming
Date: Thu, 03 Nov 2022 14:24:13 +0100 [thread overview]
Message-ID: <87iljwmarm.wl-tiwai@suse.de> (raw)
In-Reply-To: <87k04cmavy.wl-tiwai@suse.de>
On Thu, 03 Nov 2022 14:21:37 +0100,
Takashi Iwai wrote:
>
> On Thu, 03 Nov 2022 14:11:43 +0100,
> Jason Montleon wrote:
> >
> > Starting with 6.0-rc1 these messages are logged and the sound card
> > is unavailable. Adding legacy_dai_naming to the rt5514-spi causes
> > it to function properly again.
> >
> > [ 16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI
> > spi-PRP0001:00 not registered
> > [ 16.928561] platform kbl_r5514_5663_max: deferred probe pending
>
> Please avoid hanging on the existing thread if you resubmit a new
> patch set.
>
> Also, more importantly, your Signed-off-by tag is missing. It's a
> legal requirement.
>
> At the next time, run scripts/checkpatch.pl before the submission.
> It'll catch such errors.
Also, it's better to have a few more things in the patches:
- Fixes tag indicating the buggy commit to be fixed
- Link (or BugLink tag) to pointing to the kernel bugzilla URL
- Cc-to-stable tag, to assure the fix going to 6.0.y stable tree
Takashi
next prev parent reply other threads:[~2022-11-03 13:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 20:05 [PATCH] Fix kbl_rt5663_rt5514_max98927 regression Jason Montleon
2022-11-02 21:09 ` Jason Montleon
2022-11-03 11:54 ` [PATCH] Fix kbl_rt5663_rt5514_max98927 regression #forregzbot Thorsten Leemhuis
2022-11-02 22:05 ` [PATCH] Fix kbl_rt5663_rt5514_max98927 regression Pierre-Louis Bossart
2022-11-03 7:59 ` Takashi Iwai
2022-11-03 7:59 ` Takashi Iwai
2022-11-03 9:54 ` Charles Keepax
2022-11-03 9:54 ` Charles Keepax
2022-11-03 11:13 ` Takashi Iwai
2022-11-03 11:13 ` Takashi Iwai
2022-11-03 13:11 ` [PATCH v2 1/2] ASoC: rt5514: fix legacy dai naming Jason Montleon
2022-11-03 13:11 ` Jason Montleon
2022-11-03 13:11 ` [PATCH v2 2/2] ASoC: rt5677: " Jason Montleon
2022-11-03 13:11 ` Jason Montleon
2022-11-03 13:19 ` [PATCH v2 1/2] ASoC: rt5514: " Mark Brown
2022-11-03 13:19 ` Mark Brown
2022-11-03 13:21 ` Takashi Iwai
2022-11-03 13:21 ` Takashi Iwai
2022-11-03 13:24 ` Takashi Iwai [this message]
2022-11-03 13:24 ` Takashi Iwai
2022-11-03 15:00 ` Thorsten Leemhuis
2022-11-03 15:00 ` Thorsten Leemhuis
2022-11-03 13:20 ` [PATCH] Fix kbl_rt5663_rt5514_max98927 regression Jason Montleon
2022-11-03 13:20 ` Jason Montleon
2022-11-03 11:57 ` [PATCH] Fix kbl_rt5663_rt5514_max98927 regression #forregzbot Thorsten Leemhuis
2022-11-05 10:13 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iljwmarm.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=jmontleo@redhat.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=regressions@lists.linux.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.