Re: [PATCH 15/50] wifi: ath12k: add dp_rx.c

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Kalle Valo <kvalo@kernel.org>
To: "Sriram R \(QUIC\)" <quic_srirrama@quicinc.com>
Cc: "Jeff Johnson \(QUIC\)" <quic_jjohnson@quicinc.com>,
	 "linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	 "ath12k\@lists.infradead.org" <ath12k@lists.infradead.org>
Subject: Re: [PATCH 15/50] wifi: ath12k: add dp_rx.c
Date: Fri, 21 Oct 2022 16:30:04 +0300	[thread overview]
Message-ID: <87ilkdi9sz.fsf@kernel.org> (raw)
In-Reply-To: <SN6PR02MB4334C052EA71CD13F0506E55F7259@SN6PR02MB4334.namprd02.prod.outlook.com> (Sriram R.'s message of "Thu, 13 Oct 2022 05:54:54 +0000")

"Sriram R (QUIC)" <quic_srirrama@quicinc.com> writes:

>>> +static void ath12k_dp_rx_process_received_packets(struct ath12k_base
>>*ab,
>>> +                                               struct napi_struct *napi,
>>> +                                               struct sk_buff_head *msdu_list,
>>> +                                               int ring_id) {
>>> +     struct ieee80211_rx_status rx_status = {0};
>>
>>initializing just on entry seems wrong, see below
>
> We reset the whole struct once, and reset the necessary fields alone
> for every loop within ath12k_dp_rx_h_ppdu or similar places as
> necessary and pass the status to mac80211. The initial reset is
> necessary so as to reset all unused fields. This is an optimization to
> not memset the struct for every loop.

It would be good to document such optimisations with a comment,
otherwise people might be confused.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

WARNING: multiple messages have this Message-ID (diff)

From: Kalle Valo <kvalo@kernel.org>
To: "Sriram R \(QUIC\)" <quic_srirrama@quicinc.com>
Cc: "Jeff Johnson \(QUIC\)" <quic_jjohnson@quicinc.com>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	"ath12k\@lists.infradead.org" <ath12k@lists.infradead.org>
Subject: Re: [PATCH 15/50] wifi: ath12k: add dp_rx.c
Date: Fri, 21 Oct 2022 16:30:04 +0300	[thread overview]
Message-ID: <87ilkdi9sz.fsf@kernel.org> (raw)
In-Reply-To: <SN6PR02MB4334C052EA71CD13F0506E55F7259@SN6PR02MB4334.namprd02.prod.outlook.com> (Sriram R.'s message of "Thu, 13 Oct 2022 05:54:54 +0000")

"Sriram R (QUIC)" <quic_srirrama@quicinc.com> writes:

>>> +static void ath12k_dp_rx_process_received_packets(struct ath12k_base
>>*ab,
>>> +                                               struct napi_struct *napi,
>>> +                                               struct sk_buff_head *msdu_list,
>>> +                                               int ring_id) {
>>> +     struct ieee80211_rx_status rx_status = {0};
>>
>>initializing just on entry seems wrong, see below
>
> We reset the whole struct once, and reset the necessary fields alone
> for every loop within ath12k_dp_rx_h_ppdu or similar places as
> necessary and pass the status to mac80211. The initial reset is
> necessary so as to reset all unused fields. This is an optimization to
> not memset the struct for every loop.

It would be good to document such optimisations with a comment,
otherwise people might be confused.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

next prev parent reply	other threads:[~2022-10-21 13:30 UTC|newest]

Thread overview: 265+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 16:09 [PATCH 00/50] wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices Kalle Valo
2022-08-12 16:09 ` Kalle Valo
2022-08-12 16:09 ` [PATCH 01/50] wifi: ath12k: add Kconfig Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 02/50] wifi: ath12k: add Makefile Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 03/50] wifi: ath12k: add ce.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-09-13  4:28   ` Ping-Ke Shih
2022-09-13  4:28     ` Ping-Ke Shih
2022-10-04 11:08     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:08       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 04/50] wifi: ath12k: add ce.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 05/50] wifi: ath12k: add core.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-09-13  6:18   ` Ping-Ke Shih
2022-09-13  6:18     ` Ping-Ke Shih
2022-10-12 23:12     ` Sriram R (QUIC)
2022-10-12 23:12       ` Sriram R (QUIC)
2022-10-21  8:32     ` Kalle Valo
2022-10-21  8:32       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 06/50] wifi: ath12k: add core.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-13  0:16   ` Jeff Johnson
2022-08-13  0:16     ` Jeff Johnson
2022-10-21 10:58     ` Kalle Valo
2022-10-21 10:58       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 07/50] wifi: ath12k: add dbring.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-15 19:55   ` Jeff Johnson
2022-10-21 11:06     ` Kalle Valo
2022-10-21 11:06       ` Kalle Valo
2022-11-09  9:12       ` Kalle Valo
2022-11-09  9:12         ` Kalle Valo
2022-08-12 16:09 ` [PATCH 08/50] wifi: ath12k: add dbring.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-15 19:59   ` Jeff Johnson
2022-10-21 11:07     ` Kalle Valo
2022-10-21 11:07       ` Kalle Valo
2022-10-21 11:12       ` Kalle Valo
2022-10-21 11:12         ` Kalle Valo
2022-08-12 16:09 ` [PATCH 09/50] wifi: ath12k: add debug.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 10/50] wifi: ath12k: add debug.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-15 20:11   ` Jeff Johnson
2022-10-21 11:18     ` Kalle Valo
2022-10-21 11:18       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 11/50] wifi: ath12k: add dp.c Kalle Valo
2022-10-11 19:20   ` Pradeep Kumar Chitrapu
2022-08-12 16:09   ` Kalle Valo
2022-08-16 15:17   ` Jeff Johnson
2022-08-16 15:17     ` Jeff Johnson
     [not found]     ` <CH0PR02MB82123C176B0E05156B66C9F1F6229@CH0PR02MB8212.namprd02.prod.outlook.com>
     [not found]       ` <94e894a8-a262-959e-a6ab-869dcba9e0fa@quicinc.com>
2022-10-13 16:37         ` Pradeep Kumar Chitrapu
2022-10-13 16:37           ` Pradeep Kumar Chitrapu
2022-10-13 20:17         ` Jeff Johnson
2022-10-13 20:17           ` Jeff Johnson
2022-10-21 11:43     ` Kalle Valo
2022-10-21 11:43       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 12/50] wifi: ath12k: add dp.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-15  1:56   ` Ping-Ke Shih
2022-08-15  1:56     ` Ping-Ke Shih
2022-09-05 17:27     ` Kalle Valo
2022-09-05 17:27       ` Kalle Valo
2022-10-21 11:45       ` Kalle Valo
2022-10-21 11:45         ` Kalle Valo
2022-08-12 16:09 ` [PATCH 13/50] wifi: ath12k: add dp_mon.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-16 20:13   ` Jeff Johnson
2022-08-16 20:13     ` Jeff Johnson
2022-10-21 13:07     ` Kalle Valo
2022-10-21 13:07       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 14/50] wifi: ath12k: add dp_mon.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 15/50] wifi: ath12k: add dp_rx.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-17  0:37   ` Jeff Johnson
2022-08-17  0:37     ` Jeff Johnson
2022-10-12 23:29     ` Sriram R (QUIC)
2022-10-12 23:29       ` Sriram R (QUIC)
2022-10-13  6:48       ` Jeff Johnson
2022-10-13  6:48         ` Jeff Johnson
2022-10-14  2:43         ` Sriram R (QUIC)
2022-10-14  2:43           ` Sriram R (QUIC)
2022-10-14  3:01     ` Sriram R (QUIC)
2022-10-14  3:01       ` Sriram R (QUIC)
2022-10-21 13:13       ` Kalle Valo
2022-10-21 13:13         ` Kalle Valo
2022-08-17 23:19   ` Jeff Johnson
2022-08-17 23:19     ` Jeff Johnson
2022-10-12 23:27     ` Sriram R (QUIC)
2022-10-12 23:27       ` Sriram R (QUIC)
2022-10-12 23:39     ` Sriram R (QUIC)
2022-10-12 23:39       ` Sriram R (QUIC)
2022-10-13  6:50       ` Jeff Johnson
2022-10-13  6:50         ` Jeff Johnson
2022-10-14  2:43         ` Sriram R (QUIC)
2022-10-14  2:43           ` Sriram R (QUIC)
2022-10-13  5:54     ` Sriram R (QUIC)
2022-10-13  5:54       ` Sriram R (QUIC)
2022-10-21 13:30       ` Kalle Valo [this message]
2022-10-21 13:30         ` Kalle Valo
2022-10-21 13:52     ` Kalle Valo
2022-10-21 13:52       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 16/50] wifi: ath12k: add dp_rx.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 17/50] wifi: ath12k: add dp_tx.c Kalle Valo
2022-10-11 19:20   ` Pradeep Kumar Chitrapu
2022-08-12 16:09   ` Kalle Valo
2022-08-17 23:35   ` Jeff Johnson
2022-08-17 23:35     ` Jeff Johnson
     [not found]     ` <CH0PR02MB821206158809DF78955A0EC8F6249@CH0PR02MB8212.namprd02.prod.outlook.com>
2022-10-14  7:49       ` Pradeep Kumar Chitrapu
2022-10-14  7:49         ` Pradeep Kumar Chitrapu
2022-11-08 13:14     ` Kalle Valo
2022-11-08 13:14       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 18/50] wifi: ath12k: add dp_tx.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 19/50] wifi: ath12k: add hal.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-17 23:52   ` Jeff Johnson
2022-08-17 23:52     ` Jeff Johnson
2022-10-04 11:13     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:13       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 20/50] wifi: ath12k: add hal.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 21/50] wifi: ath12k: add hal_desc.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 22/50] wifi: ath12k: add hal_rx.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 23/50] wifi: ath12k: add hal_rx.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18  0:21   ` Jeff Johnson
2022-08-18  0:21     ` Jeff Johnson
2022-10-04 11:15     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:15       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 24/50] wifi: ath12k: add hal_tx.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 17:21   ` Jeff Johnson
2022-08-18 17:21     ` Jeff Johnson
2022-10-04 11:20     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:20       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 25/50] wifi: ath12k: add hal_tx.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 26/50] wifi: ath12k: add hif.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 27/50] wifi: ath12k: add htc.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 19:33   ` Jeff Johnson
2022-08-18 19:33     ` Jeff Johnson
2022-10-04 11:23     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:23       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 28/50] wifi: ath12k: add htc.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 21:10   ` Jeff Johnson
2022-08-18 21:10     ` Jeff Johnson
2022-10-04 11:27     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:27       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 29/50] wifi: ath12k: add hw.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 21:31   ` Jeff Johnson
2022-08-18 21:31     ` Jeff Johnson
2022-10-04 11:28     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:28       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 30/50] wifi: ath12k: add hw.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 22:30   ` Jeff Johnson
2022-08-18 22:30     ` Jeff Johnson
2022-11-08 13:27     ` Kalle Valo
2022-11-08 13:27       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 31/50] wifi: ath12k: add mac.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-15  6:09   ` Ping-Ke Shih
2022-08-15  6:09     ` Ping-Ke Shih
2022-09-05 17:31     ` Kalle Valo
2022-09-05 17:31       ` Kalle Valo
2022-08-16 18:09   ` Jeff Johnson
2022-08-16 18:09     ` Jeff Johnson
2022-11-08 13:55     ` Kalle Valo
2022-11-08 13:55       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 32/50] wifi: ath12k: add mac.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 33/50] wifi: ath12k: add mhi.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 22:25   ` Jeff Johnson
2022-08-18 22:25     ` Jeff Johnson
2022-08-19 18:56     ` Jeff Johnson
2022-08-19 18:56       ` Jeff Johnson
2022-11-08 14:00     ` Kalle Valo
2022-11-08 14:00       ` Kalle Valo
2022-11-09 16:49       ` Jeff Johnson
2022-11-09 16:49         ` Jeff Johnson
2022-08-12 16:09 ` [PATCH 34/50] wifi: ath12k: add mhi.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 22:30   ` Jeff Johnson
2022-08-18 22:30     ` Jeff Johnson
2022-11-08 14:01     ` Kalle Valo
2022-11-08 14:01       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 35/50] wifi: ath12k: add pci.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 23:02   ` Jeff Johnson
2022-08-18 23:02     ` Jeff Johnson
2022-11-08 14:45     ` Kalle Valo
2022-11-08 14:45       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 36/50] wifi: ath12k: add pci.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 23:18   ` Jeff Johnson
2022-08-18 23:18     ` Jeff Johnson
2022-11-08 14:56     ` Kalle Valo
2022-11-08 14:56       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 37/50] wifi: ath12k: add peer.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-18 23:34   ` Jeff Johnson
2022-08-18 23:34     ` Jeff Johnson
2022-10-04 11:30     ` Karthikeyan Periyasamy (QUIC)
2022-10-04 11:30       ` Karthikeyan Periyasamy (QUIC)
2022-08-12 16:09 ` [PATCH 38/50] wifi: ath12k: add peer.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-17 19:25   ` Jeff Johnson
2022-08-17 19:25     ` Jeff Johnson
2022-10-12 23:13     ` Sriram R (QUIC)
2022-10-12 23:13       ` Sriram R (QUIC)
2022-08-12 16:09 ` [PATCH 39/50] wifi: ath12k: add qmi.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-22 17:14   ` Jeff Johnson
2022-08-22 17:14     ` Jeff Johnson
2022-11-08 14:59     ` Kalle Valo
2022-11-08 14:59       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 40/50] wifi: ath12k: add qmi.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-19  0:25   ` Jeff Johnson
2022-08-19  0:25     ` Jeff Johnson
2022-11-08 15:06     ` Kalle Valo
2022-11-08 15:06       ` Kalle Valo
2022-08-12 16:09 ` [PATCH 41/50] wifi: ath12k: add reg.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 42/50] wifi: ath12k: add reg.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 43/50] wifi: ath12k: add rx_desc.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 44/50] wifi: ath12k: add trace.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 45/50] wifi: ath12k: add trace.h Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-12 16:09 ` [PATCH 46/50] wifi: ath12k: add wmi.c Kalle Valo
2022-08-12 16:09   ` Kalle Valo
2022-08-19 20:45   ` Jeff Johnson
2022-08-19 20:45     ` Jeff Johnson
2022-09-07  7:36   ` Ping-Ke Shih
2022-09-07  7:36     ` Ping-Ke Shih
2022-11-08 15:40     ` Kalle Valo
2022-11-08 15:40       ` Kalle Valo
2022-08-12 16:10 ` [PATCH 47/50] wifi: ath12k: add wmi.h Kalle Valo
2022-08-12 16:10   ` Kalle Valo
2022-08-19  1:11   ` Jeff Johnson
2022-08-19  1:11     ` Jeff Johnson
2022-11-08 15:43     ` Kalle Valo
2022-11-08 15:43       ` Kalle Valo
2022-08-12 16:10 ` [PATCH 48/50] wifi: ath: add ath12k to Makefile Kalle Valo
2022-08-12 16:10   ` Kalle Valo
2022-08-12 16:10 ` [PATCH 49/50] wifi: ath: add ath12k to Kconfig Kalle Valo
2022-08-12 16:10   ` Kalle Valo
2022-08-12 16:10 ` [PATCH 50/50] MAINTAINERS: add ath12k Kalle Valo
2022-08-12 16:10   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilkdi9sz.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=quic_srirrama@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.