From: Jani Nikula <jani.nikula@linux.intel.com>
To: Pablo Ceballos <pceballos@google.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Maxime Ripard <maxime@cerno.tech>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
Pablo Ceballos <pceballos@google.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/lspcon: Increase LSPCON mode settle timeout
Date: Tue, 04 Oct 2022 20:38:24 +0300 [thread overview]
Message-ID: <87ilkzsd4f.fsf@intel.com> (raw)
In-Reply-To: <20220915004601.320198-1-pceballos@google.com>
On Thu, 15 Sep 2022, Pablo Ceballos <pceballos@google.com> wrote:
> On some devices the Parade PS175 takes more than 400ms to settle in PCON
> mode.
Got any bug report with more info, or any other details to back this up?
This is kind of thin. What's the 800 ms based on?
BR,
Jani.
>
> Signed-off-by: Pablo Ceballos <pceballos@google.com>
> ---
> drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index 15d59de8810e..b4cbade13ee5 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -166,7 +166,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
> drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
> lspcon_mode_name(mode));
>
> - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
> + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800);
> if (current_mode != mode)
> drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Pablo Ceballos <pceballos@google.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Maxime Ripard <maxime@cerno.tech>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
Pablo Ceballos <pceballos@google.com>
Subject: Re: [PATCH] drm/i915/display/lspcon: Increase LSPCON mode settle timeout
Date: Tue, 04 Oct 2022 20:38:24 +0300 [thread overview]
Message-ID: <87ilkzsd4f.fsf@intel.com> (raw)
In-Reply-To: <20220915004601.320198-1-pceballos@google.com>
On Thu, 15 Sep 2022, Pablo Ceballos <pceballos@google.com> wrote:
> On some devices the Parade PS175 takes more than 400ms to settle in PCON
> mode.
Got any bug report with more info, or any other details to back this up?
This is kind of thin. What's the 800 ms based on?
BR,
Jani.
>
> Signed-off-by: Pablo Ceballos <pceballos@google.com>
> ---
> drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index 15d59de8810e..b4cbade13ee5 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -166,7 +166,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
> drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
> lspcon_mode_name(mode));
>
> - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
> + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800);
> if (current_mode != mode)
> drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Pablo Ceballos <pceballos@google.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Pablo Ceballos" <pceballos@google.com>,
"Maxime Ripard" <maxime@cerno.tech>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/display/lspcon: Increase LSPCON mode settle timeout
Date: Tue, 04 Oct 2022 20:38:24 +0300 [thread overview]
Message-ID: <87ilkzsd4f.fsf@intel.com> (raw)
In-Reply-To: <20220915004601.320198-1-pceballos@google.com>
On Thu, 15 Sep 2022, Pablo Ceballos <pceballos@google.com> wrote:
> On some devices the Parade PS175 takes more than 400ms to settle in PCON
> mode.
Got any bug report with more info, or any other details to back this up?
This is kind of thin. What's the 800 ms based on?
BR,
Jani.
>
> Signed-off-by: Pablo Ceballos <pceballos@google.com>
> ---
> drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index 15d59de8810e..b4cbade13ee5 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -166,7 +166,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
> drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
> lspcon_mode_name(mode));
>
> - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
> + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800);
> if (current_mode != mode)
> drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-10-04 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 0:46 [Intel-gfx] [PATCH] drm/i915/display/lspcon: Increase LSPCON mode settle timeout Pablo Ceballos
2022-09-15 0:46 ` Pablo Ceballos
2022-09-15 0:46 ` Pablo Ceballos
2022-09-19 19:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-09-19 19:58 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-09-19 20:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-10-04 17:38 ` Jani Nikula [this message]
2022-10-04 17:38 ` [PATCH] " Jani Nikula
2022-10-04 17:38 ` Jani Nikula
2022-10-06 22:59 ` [Intel-gfx] " Pablo Ceballos
2022-10-06 22:59 ` Pablo Ceballos
2022-10-06 22:59 ` Pablo Ceballos
2022-10-13 7:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/lspcon: Increase LSPCON mode settle timeout (rev2) Patchwork
2022-10-13 9:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilkzsd4f.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=pceballos@google.com \
--cc=rodrigo.vivi@intel.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.