From: "Alex Bennée" <alex.bennee@linaro.org>
To: Idan Horowitz <idan.horowitz@gmail.com>
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-arm@nongnu.org
Subject: Re: [PATCH 1/2] accel/tcg: Optimize jump cache flush during tlb range flush
Date: Fri, 14 Jan 2022 15:48:54 +0000 [thread overview]
Message-ID: <87ilum8gfp.fsf@linaro.org> (raw)
In-Reply-To: <20220110164754.1066025-1-idan.horowitz@gmail.com>
Idan Horowitz <idan.horowitz@gmail.com> writes:
> When the length of the range is large enough, clearing the whole cache is
> faster than iterating over the (possibly extremely large) set of pages
> contained in the range.
>
> This mimics the pre-existing similar optimization done on the flush of the
> tlb itself.
>
> Signed-off-by: Idan Horowitz <idan.horowitz@gmail.com>
For multi-patch series please include a cover letter which is the parent
of all the patches. This is the default for git-send-email.
The code itself looks fine but what sort of improvements are we talking
about here? What measurements have you taken and under what conditions?
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Idan Horowitz <idan.horowitz@gmail.com>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
pbonzini@redhat.com
Subject: Re: [PATCH 1/2] accel/tcg: Optimize jump cache flush during tlb range flush
Date: Fri, 14 Jan 2022 15:48:54 +0000 [thread overview]
Message-ID: <87ilum8gfp.fsf@linaro.org> (raw)
In-Reply-To: <20220110164754.1066025-1-idan.horowitz@gmail.com>
Idan Horowitz <idan.horowitz@gmail.com> writes:
> When the length of the range is large enough, clearing the whole cache is
> faster than iterating over the (possibly extremely large) set of pages
> contained in the range.
>
> This mimics the pre-existing similar optimization done on the flush of the
> tlb itself.
>
> Signed-off-by: Idan Horowitz <idan.horowitz@gmail.com>
For multi-patch series please include a cover letter which is the parent
of all the patches. This is the default for git-send-email.
The code itself looks fine but what sort of improvements are we talking
about here? What measurements have you taken and under what conditions?
--
Alex Bennée
next prev parent reply other threads:[~2022-01-14 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 16:47 [PATCH 1/2] accel/tcg: Optimize jump cache flush during tlb range flush Idan Horowitz
2022-01-10 16:47 ` [PATCH 2/2] target/arm: Bail out early on 0-length tlb range invalidate Idan Horowitz
2022-01-25 22:05 ` Richard Henderson
2022-01-25 22:06 ` Peter Maydell
2022-01-25 23:34 ` Richard Henderson
2022-01-14 15:48 ` Alex Bennée [this message]
2022-01-14 15:48 ` [PATCH 1/2] accel/tcg: Optimize jump cache flush during tlb range flush Alex Bennée
2022-01-14 16:41 ` Idan Horowitz
2022-01-14 16:41 ` Idan Horowitz
2022-01-14 20:56 ` Idan Horowitz
2022-01-14 20:56 ` Idan Horowitz
2022-01-25 21:55 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilum8gfp.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=idan.horowitz@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.