All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, f4bug@amsat.org,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Andrew Baumann" <Andrew.Baumann@microsoft.com>
Subject: Re: [PATCH  v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2
Date: Mon, 04 Oct 2021 16:43:50 +0100	[thread overview]
Message-ID: <87ilycg5fu.fsf@linaro.org> (raw)
In-Reply-To: <20211004134742.2044280-6-alex.bennee@linaro.org>


Alex Bennée <alex.bennee@linaro.org> writes:

> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> The BCM2711 is improvement of the BCM2837:
> - Cortex-A72 instead of the A53
> - peripheral block and local soc controller are mapped differently,
> - GICv2
> - PCIe block
> - exhanced MMU to address over 4GiB of SDRAM
>
<snip>
> ---
> vAJB:
<snip>
>   - move peri_base/ctrl to locations pointed to by DTB (0x7e000000/0x40000000)
<snip>
> +
> +static void bcm2711_class_init(ObjectClass *oc, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(oc);
> +    BCM283XClass *bc = BCM283X_CLASS(oc);
> +
> +    bc->cpu_type = ARM_CPU_TYPE_NAME("cortex-a72");
> +    bc->core_count = BCM283X_NCPUS;
> +    bc->peri_base = 0x7e000000;
> +    bc->ctrl_base = 0x40000000;
> +    bc->clusterid = 0x0;
> +    bc->gic_base = 0x40000,
> +    dc->realize = bcm2836_realize;
> +}

It turns out I was misreading the way you calculate addresses from DTS
files. Reverted to:

    bc->peri_base = 0xfe000000;
    bc->ctrl_base = 0xff800000;

-- 
Alex Bennée

WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	f4bug@amsat.org, "Andrew Baumann" <Andrew.Baumann@microsoft.com>
Subject: Re: [PATCH v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2
Date: Mon, 04 Oct 2021 16:43:50 +0100	[thread overview]
Message-ID: <87ilycg5fu.fsf@linaro.org> (raw)
In-Reply-To: <20211004134742.2044280-6-alex.bennee@linaro.org>


Alex Bennée <alex.bennee@linaro.org> writes:

> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> The BCM2711 is improvement of the BCM2837:
> - Cortex-A72 instead of the A53
> - peripheral block and local soc controller are mapped differently,
> - GICv2
> - PCIe block
> - exhanced MMU to address over 4GiB of SDRAM
>
<snip>
> ---
> vAJB:
<snip>
>   - move peri_base/ctrl to locations pointed to by DTB (0x7e000000/0x40000000)
<snip>
> +
> +static void bcm2711_class_init(ObjectClass *oc, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(oc);
> +    BCM283XClass *bc = BCM283X_CLASS(oc);
> +
> +    bc->cpu_type = ARM_CPU_TYPE_NAME("cortex-a72");
> +    bc->core_count = BCM283X_NCPUS;
> +    bc->peri_base = 0x7e000000;
> +    bc->ctrl_base = 0x40000000;
> +    bc->clusterid = 0x0;
> +    bc->gic_base = 0x40000,
> +    dc->realize = bcm2836_realize;
> +}

It turns out I was misreading the way you calculate addresses from DTS
files. Reverted to:

    bc->peri_base = 0xfe000000;
    bc->ctrl_base = 0xff800000;

-- 
Alex Bennée


  reply	other threads:[~2021-10-04 15:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 13:47 [PATCH v1 0/7] enabling RasperryPi 4 emulation - WIP state Alex Bennée
2021-10-04 13:47 ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 1/7] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory Alex Bennée
2021-10-04 13:47   ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property Alex Bennée
2021-10-04 13:47   ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 3/7] hw/arm: fix the position of vcram for raspi Alex Bennée
2021-10-04 13:47   ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 4/7] hw/arm/bcm2835_peripherals: Map various BCM2711 blocks Alex Bennée
2021-10-04 13:47   ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2 Alex Bennée
2021-10-04 13:47   ` Alex Bennée
2021-10-04 15:43   ` Alex Bennée [this message]
2021-10-04 15:43     ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 6/7] hw/arm/bcm2838: Map the PCIe memory space Alex Bennée
2021-10-04 13:47   ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 7/7] hw/arm/raspi: Add the Raspberry Pi 4B board Alex Bennée
2021-10-04 13:47   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilycg5fu.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.