From: Daniel Axtens <dja@axtens.net>
To: Marco Elver <elver@google.com>
Cc: aneesh.kumar@linux.ibm.com, LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
kasan-dev <kasan-dev@googlegroups.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v12 1/6] kasan: allow an architecture to disable inline instrumentation
Date: Wed, 16 Jun 2021 14:39:38 +1000 [thread overview]
Message-ID: <87im2ev2wl.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <CANpmjNOa-a=M-EgdkneiWDD0eCF-DELjMFxAeJzGQz6AgCdNWg@mail.gmail.com>
Hi Marco,
@@ -12,6 +12,15 @@ config HAVE_ARCH_KASAN_HW_TAGS
>> config HAVE_ARCH_KASAN_VMALLOC
>> bool
>>
>> +# Sometimes an architecture might not be able to support inline instrumentation
>> +# but might be able to support outline instrumentation. This option allows an
>> +# arch to prevent inline and stack instrumentation from being enabled.
>
> This comment could be moved into 'help' of this new config option.
It could. I did wonder if that made sense given that this is not a user
selectable option so I'm not sure if the help will ever be visible, but
I see that we do this sort of thing in Kconfig.kcsan and Kconfig.kgdb.
I've changed it over.
>> +# ppc64 turns on virtual memory late in boot, after calling into generic code
>> +# like the device-tree parser, so it uses this in conjuntion with a hook in
>> +# outline mode to avoid invalid access early in boot.
>
> I think the ppc64-related comment isn't necessary and can be moved to
> arch/ppc64 somewhere, if there isn't one already.
Fair enough. I'll pull it out of this file and look for a good place to
put the information in arch/powerpc in a later patch/series.
Kind regards,
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Axtens <dja@axtens.net>
To: Marco Elver <elver@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linuxppc-dev@lists.ozlabs.org,
kasan-dev <kasan-dev@googlegroups.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
aneesh.kumar@linux.ibm.com, Balbir Singh <bsingharora@gmail.com>
Subject: Re: [PATCH v12 1/6] kasan: allow an architecture to disable inline instrumentation
Date: Wed, 16 Jun 2021 14:39:38 +1000 [thread overview]
Message-ID: <87im2ev2wl.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <CANpmjNOa-a=M-EgdkneiWDD0eCF-DELjMFxAeJzGQz6AgCdNWg@mail.gmail.com>
Hi Marco,
@@ -12,6 +12,15 @@ config HAVE_ARCH_KASAN_HW_TAGS
>> config HAVE_ARCH_KASAN_VMALLOC
>> bool
>>
>> +# Sometimes an architecture might not be able to support inline instrumentation
>> +# but might be able to support outline instrumentation. This option allows an
>> +# arch to prevent inline and stack instrumentation from being enabled.
>
> This comment could be moved into 'help' of this new config option.
It could. I did wonder if that made sense given that this is not a user
selectable option so I'm not sure if the help will ever be visible, but
I see that we do this sort of thing in Kconfig.kcsan and Kconfig.kgdb.
I've changed it over.
>> +# ppc64 turns on virtual memory late in boot, after calling into generic code
>> +# like the device-tree parser, so it uses this in conjuntion with a hook in
>> +# outline mode to avoid invalid access early in boot.
>
> I think the ppc64-related comment isn't necessary and can be moved to
> arch/ppc64 somewhere, if there isn't one already.
Fair enough. I'll pull it out of this file and look for a good place to
put the information in arch/powerpc in a later patch/series.
Kind regards,
Daniel
next prev parent reply other threads:[~2021-06-16 4:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 1:46 [PATCH v12 0/6] KASAN core changes for ppc64 radix KASAN Daniel Axtens
2021-06-15 1:47 ` [PATCH v12 1/6] kasan: allow an architecture to disable inline instrumentation Daniel Axtens
2021-06-15 7:46 ` Marco Elver
2021-06-15 7:46 ` Marco Elver
2021-06-16 4:39 ` Daniel Axtens [this message]
2021-06-16 4:39 ` Daniel Axtens
2021-06-15 1:47 ` [PATCH v12 2/6] kasan: allow architectures to provide an outline readiness check Daniel Axtens
2021-06-15 1:47 ` Daniel Axtens
2021-06-15 10:08 ` Marco Elver
2021-06-15 10:08 ` Marco Elver
2021-06-16 4:41 ` Daniel Axtens
2021-06-16 4:41 ` Daniel Axtens
2021-06-15 1:47 ` [PATCH v12 3/6] kasan: define and use MAX_PTRS_PER_* for early shadow tables Daniel Axtens
2021-06-15 1:47 ` [PATCH v12 4/6] kasan: Document support on 32-bit powerpc Daniel Axtens
2021-06-15 1:47 ` [PATCH v12 5/6] powerpc/mm/kasan: rename kasan_init_32.c to init_32.c Daniel Axtens
2021-06-15 1:47 ` [PATCH v12 6/6] [RFC] powerpc: Book3S 64-bit outline-only KASAN support Daniel Axtens
2021-06-15 10:31 ` [PATCH v12 0/6] KASAN core changes for ppc64 radix KASAN Marco Elver
2021-06-15 10:31 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im2ev2wl.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=aneesh.kumar@linux.ibm.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.