From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
qemu-devel@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH v6 7/8] sparc/sun4m: Use start-powered-off CPUState property
Date: Wed, 19 Aug 2020 20:54:33 -0300 [thread overview]
Message-ID: <87imdedwee.fsf@morokweng.localdomain> (raw)
In-Reply-To: <e38d45c9-1505-d596-6c2a-e82f73dc2935@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote:
>> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
>> start-powered-off property which makes cpu_common_reset() initialize it
>> to 1 in common code.
>>
>> This makes secondary_cpu_reset() unnecessary, so remove it.
>>
>> Also remove setting of cs->halted from cpu_devinit(), which seems out of
>> place when compared to similar code in other architectures (e.g.,
>> ppce500_init() in hw/ppc/e500.c).
>>
>> Finally, change creation of CPU object from cpu_create() to object_new()
>> and qdev_realize_and_unref() because cpu_create() realizes the CPU and it's
>> not possible to set a property after the object is realized.
>>
>> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
--
Thiago Jung Bauermann
IBM Linux Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-ppc@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH v6 7/8] sparc/sun4m: Use start-powered-off CPUState property
Date: Wed, 19 Aug 2020 20:54:33 -0300 [thread overview]
Message-ID: <87imdedwee.fsf@morokweng.localdomain> (raw)
In-Reply-To: <e38d45c9-1505-d596-6c2a-e82f73dc2935@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote:
>> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
>> start-powered-off property which makes cpu_common_reset() initialize it
>> to 1 in common code.
>>
>> This makes secondary_cpu_reset() unnecessary, so remove it.
>>
>> Also remove setting of cs->halted from cpu_devinit(), which seems out of
>> place when compared to similar code in other architectures (e.g.,
>> ppce500_init() in hw/ppc/e500.c).
>>
>> Finally, change creation of CPU object from cpu_create() to object_new()
>> and qdev_realize_and_unref() because cpu_create() realizes the CPU and it's
>> not possible to set a property after the object is realized.
>>
>> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
--
Thiago Jung Bauermann
IBM Linux Technology Center
next prev parent reply other threads:[~2020-08-19 23:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 16:42 [PATCH v6 0/8] Generalize start-powered-off property from ARM Thiago Jung Bauermann
2020-08-19 16:42 ` Thiago Jung Bauermann
2020-08-19 16:42 ` [PATCH v6 1/8] target/arm: Move start-powered-off property to generic CPUState Thiago Jung Bauermann
2020-08-19 16:42 ` Thiago Jung Bauermann
2020-08-19 16:43 ` [PATCH v6 2/8] target/arm: Move setting of CPU halted state to generic code Thiago Jung Bauermann
2020-08-19 16:43 ` Thiago Jung Bauermann
2020-08-19 16:43 ` [PATCH v6 3/8] ppc/spapr: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-08-19 16:43 ` Thiago Jung Bauermann
2020-08-19 16:43 ` [PATCH v6 4/8] ppc/e500: " Thiago Jung Bauermann
2020-08-19 16:43 ` Thiago Jung Bauermann
2020-08-22 8:59 ` Cédric Le Goater
2020-08-22 8:59 ` Cédric Le Goater
2020-08-22 14:35 ` Philippe Mathieu-Daudé
2020-08-22 14:35 ` Philippe Mathieu-Daudé
2020-08-24 23:34 ` Thiago Jung Bauermann
2020-08-24 23:34 ` Thiago Jung Bauermann
2020-08-26 5:48 ` Thiago Jung Bauermann
2020-08-26 5:48 ` Thiago Jung Bauermann
2020-08-23 7:14 ` David Gibson
2020-08-23 7:14 ` David Gibson
2020-08-24 23:33 ` Thiago Jung Bauermann
2020-08-24 23:33 ` Thiago Jung Bauermann
2020-08-19 16:43 ` [PATCH v6 5/8] mips/cps: " Thiago Jung Bauermann
2020-08-19 16:43 ` Thiago Jung Bauermann
2020-08-19 16:43 ` [PATCH v6 6/8] sparc/sun4m: Remove main_cpu_reset() Thiago Jung Bauermann
2020-08-19 16:43 ` Thiago Jung Bauermann
2020-08-26 3:09 ` Thiago Jung Bauermann
2020-08-26 3:09 ` Thiago Jung Bauermann
2020-08-19 16:43 ` [PATCH v6 7/8] sparc/sun4m: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-08-19 16:43 ` Thiago Jung Bauermann
2020-08-19 17:03 ` Philippe Mathieu-Daudé
2020-08-19 17:03 ` Philippe Mathieu-Daudé
2020-08-19 23:54 ` Thiago Jung Bauermann [this message]
2020-08-19 23:54 ` Thiago Jung Bauermann
2020-08-19 16:43 ` [PATCH v6 8/8] target/s390x: " Thiago Jung Bauermann
2020-08-19 16:43 ` Thiago Jung Bauermann
2020-08-20 1:42 ` [PATCH v6 0/8] Generalize start-powered-off property from ARM David Gibson
2020-08-20 1:42 ` David Gibson
2020-08-20 2:04 ` Thiago Jung Bauermann
2020-08-20 2:04 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imdedwee.fsf@morokweng.localdomain \
--to=bauerman@linux.ibm.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.