All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] soc: bcm: Make PM driver default for BCM2835
@ 2019-01-24 18:04 Stefan Wahren
  2019-01-24 18:15 ` Eric Anholt
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Wahren @ 2019-01-24 18:04 UTC (permalink / raw)
  To: Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt
  Cc: Stefan Wahren, Arnd Bergmann, Catalin Marinas, Will Deacon,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the
PM driver instead of firmware.") VC4 on BCM2835 requires the power driver.

Otherwise the driver won't probe and HDMI output stays black:
vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 drivers/soc/bcm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Changes in V2:
- make driver default for BCM2835 instead of selecting in platform Kconfig
  as suggested by Scott Branden

diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig
index fe1af29..03fa91f 100644
--- a/drivers/soc/bcm/Kconfig
+++ b/drivers/soc/bcm/Kconfig
@@ -3,6 +3,7 @@ menu "Broadcom SoC drivers"
 config BCM2835_POWER
 	bool "BCM2835 power domain driver"
 	depends on ARCH_BCM2835 || (COMPILE_TEST && OF)
+	default y if ARCH_BCM2835
 	select PM_GENERIC_DOMAINS if PM
 	select RESET_CONTROLLER
 	help
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] soc: bcm: Make PM driver default for BCM2835
  2019-01-24 18:04 [PATCH V2] soc: bcm: Make PM driver default for BCM2835 Stefan Wahren
@ 2019-01-24 18:15 ` Eric Anholt
  2019-01-24 18:53   ` Scott Branden
  2019-01-24 18:53   ` Stefan Wahren
  0 siblings, 2 replies; 4+ messages in thread
From: Eric Anholt @ 2019-01-24 18:15 UTC (permalink / raw)
  To: Stefan Wahren, Florian Fainelli, Ray Jui, Scott Branden
  Cc: Stefan Wahren, Arnd Bergmann, Catalin Marinas, Will Deacon,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 441 bytes --]

Stefan Wahren <stefan.wahren@i2se.com> writes:

> Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the
> PM driver instead of firmware.") VC4 on BCM2835 requires the power driver.
>
> Otherwise the driver won't probe and HDMI output stays black:
> vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] soc: bcm: Make PM driver default for BCM2835
  2019-01-24 18:15 ` Eric Anholt
@ 2019-01-24 18:53   ` Scott Branden
  2019-01-24 18:53   ` Stefan Wahren
  1 sibling, 0 replies; 4+ messages in thread
From: Scott Branden @ 2019-01-24 18:53 UTC (permalink / raw)
  To: Eric Anholt, Stefan Wahren, Florian Fainelli, Ray Jui,
	Scott Branden
  Cc: Arnd Bergmann, Catalin Marinas, Will Deacon,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel


On 2019-01-24 10:15 a.m., Eric Anholt wrote:
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
>> Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the
>> PM driver instead of firmware.") VC4 on BCM2835 requires the power driver.
>>
>> Otherwise the driver won't probe and HDMI output stays black:
>> vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] soc: bcm: Make PM driver default for BCM2835
  2019-01-24 18:15 ` Eric Anholt
  2019-01-24 18:53   ` Scott Branden
@ 2019-01-24 18:53   ` Stefan Wahren
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2019-01-24 18:53 UTC (permalink / raw)
  To: Eric Anholt, Florian Fainelli, Ray Jui, Scott Branden
  Cc: Arnd Bergmann, Catalin Marinas, Will Deacon,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel


> Eric Anholt <eric@anholt.net> hat am 24. Januar 2019 um 19:15 geschrieben:
> 
> 
> Stefan Wahren <stefan.wahren@i2se.com> writes:
> 
> > Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the
> > PM driver instead of firmware.") VC4 on BCM2835 requires the power driver.
> >
> > Otherwise the driver won't probe and HDMI output stays black:
> > vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> 
> Reviewed-by: Eric Anholt <eric@anholt.net>

I allowed me to applied this to bcm2835-drivers-next.

Please feel to prepare the pull requests for Florian.

Thanks
Stefan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-24 18:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24 18:04 [PATCH V2] soc: bcm: Make PM driver default for BCM2835 Stefan Wahren
2019-01-24 18:15 ` Eric Anholt
2019-01-24 18:53   ` Scott Branden
2019-01-24 18:53   ` Stefan Wahren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.