From: Vincent Bernat <vincent@bernat.ch>
To: Michal Soltys <soltys@ziu.info>
Cc: Mahesh Bandewar <mahesh@bandewar.net>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@gmail.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Mahesh Bandewar <maheshb@google.com>,
Chonggang Li <chonggangli@google.com>
Subject: Re: [next] bonding: pass link-local packets to bonding master also.
Date: Sun, 23 Dec 2018 14:16:57 +0100 [thread overview]
Message-ID: <87imzkcrhy.fsf@bernat.ch> (raw)
In-Reply-To: <a252f12d-783f-2455-570d-fe4ea622fc5c@ziu.info> (Michal Soltys's message of "Sun, 23 Dec 2018 14:06:57 +0100")
❦ 23 décembre 2018 14:06 +01, Michal Soltys <soltys@ziu.info>:
>>> Basing on what you wrote below, it seems that everything was already
>>> possible before the Chonggang Li's commit ?
>>>
>>> If I understand correctly:
>>>
>>> - if listening on master, you could get both slave interface
>>> (PACKET_ORIGDEV) as well as bonding master
>>> - if listening on slave, you would just get the slave interface
>>>
>>> Right ?
>>
>> Yes. This has been this way since 2.6.27.
>
> In the earlier thread, the author of the original patch
> said that:
>
>> The exact problem that was fixed is, when a LLDP/CDP packet is
>> received, we want to know which exact interface did it come from,
>> instead of the bonding master.
>>
>> Thanks,
>> Chonggang
>
> But if PACKET_ORIGDEV provided it (and this functionally is now broken,
> so counts as another regression - earlier bridging issues aside), maybe
> it should be just reverted ?
I think this would be better. Once fixed, I can push a change for
packet(7) to document this option as it is currently not present.
--
The last thing one knows in constructing a work is what to put first.
-- Blaise Pascal
prev parent reply other threads:[~2018-12-23 13:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 1:12 [PATCH next] bonding: pass link-local packets to bonding master also Mahesh Bandewar
2018-07-16 21:24 ` Jay Vosburgh
2018-07-16 23:53 ` Mahesh Bandewar (महेश बंडेवार)
2018-07-17 9:32 ` Michal Soltys
2018-07-17 22:17 ` Michal Soltys
2018-07-16 23:33 ` Stephen Hemminger
2018-07-16 23:57 ` Mahesh Bandewar (महेश बंडेवार)
2018-07-17 0:43 ` Stephen Hemminger
2018-07-17 9:55 ` Michal Soltys
2018-11-30 21:32 ` [next] " Vincent Bernat
2018-12-09 8:30 ` Vincent Bernat
2018-12-19 22:57 ` Michal Soltys
2018-12-20 5:55 ` Vincent Bernat
2018-12-23 13:06 ` Michal Soltys
2018-12-23 13:16 ` Vincent Bernat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imzkcrhy.fsf@bernat.ch \
--to=vincent@bernat.ch \
--cc=andy@greyhouse.net \
--cc=chonggangli@google.com \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=soltys@ziu.info \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.