All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Viktor Prutyanov" <viktor.prutyanov@phystech.edu>,
	"Richard Henderson" <rth@twiddle.net>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Amit Shah" <amit@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"John Snow" <jsnow@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Stefan Markovic" <smarkovic@wavecomp.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Fam Zheng" <famz@redhat.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Eric Blake" <eblake@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"open list:bochs" <qemu-block@nongnu.org>,
	"open list:Stellaris" <qemu-arm@nongnu.org>,
	"open list:X86" <xen-devel@lists.xenproject.org>,
	"open list:ppc4xx" <qemu-ppc@nongnu.org>
Subject: Re: [PATCH 2/2] avoid TABs in files that only contain a few
Date: Fri, 14 Dec 2018 14:02:04 +0000	[thread overview]
Message-ID: <87imzw1a1v.fsf@linaro.org> (raw)
In-Reply-To: <20181213223737.11793-3-pbonzini@redhat.com>


Paolo Bonzini <pbonzini@redhat.com> writes:

> Most files that have TABs only contain a handful of them.  Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exempted from the check.
> Outside those, after this patch the following files still contain both
> 8-space and TAB sequences at the beginning of the line.  Many of them
> have a majority of TABs, or were initially committed with all tabs.
>

For the following:

<snip>
>     tests/tcg/cris/check_addo.c
>     tests/tcg/cris/check_moveq.c
>     tests/tcg/cris/check_swap.c
>     tests/tcg/multiarch/test-mmap.c

>     tests/tcg/cris/check_abs.c
>     tests/tcg/cris/check_addc.c
>     tests/tcg/cris/check_addcm.c
>     tests/tcg/cris/check_addoq.c
>     tests/tcg/cris/check_bound.c
>     tests/tcg/cris/check_ftag.c
>     tests/tcg/cris/check_int64.c
>     tests/tcg/cris/check_lz.c
>     tests/tcg/cris/check_openpf5.c
>     tests/tcg/cris/check_sigalrm.c
>     tests/tcg/cris/crisutils.h
>     tests/tcg/cris/sys.c
>     tests/tcg/i386/test-i386-ssse3.c
<snip>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


--
Alex Bennée

WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Viktor Prutyanov" <viktor.prutyanov@phystech.edu>,
	"Richard Henderson" <rth@twiddle.net>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Amit Shah" <amit@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"John Snow" <jsnow@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Stefan Markovic" <smarkovic@wavecomp.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Fam Zheng" <famz@redhat.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Eric Blake" <eblake@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"open list:bochs" <qemu-block@nongnu.org>,
	"open list:Stellaris" <qemu-arm@nongnu.org>,
	"open list:X86" <xen-devel@lists.xenproject.org>,
	"open list:ppc4xx" <qemu-ppc@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few
Date: Fri, 14 Dec 2018 14:02:04 +0000	[thread overview]
Message-ID: <87imzw1a1v.fsf@linaro.org> (raw)
In-Reply-To: <20181213223737.11793-3-pbonzini@redhat.com>


Paolo Bonzini <pbonzini@redhat.com> writes:

> Most files that have TABs only contain a handful of them.  Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exempted from the check.
> Outside those, after this patch the following files still contain both
> 8-space and TAB sequences at the beginning of the line.  Many of them
> have a majority of TABs, or were initially committed with all tabs.
>

For the following:

<snip>
>     tests/tcg/cris/check_addo.c
>     tests/tcg/cris/check_moveq.c
>     tests/tcg/cris/check_swap.c
>     tests/tcg/multiarch/test-mmap.c

>     tests/tcg/cris/check_abs.c
>     tests/tcg/cris/check_addc.c
>     tests/tcg/cris/check_addcm.c
>     tests/tcg/cris/check_addoq.c
>     tests/tcg/cris/check_bound.c
>     tests/tcg/cris/check_ftag.c
>     tests/tcg/cris/check_int64.c
>     tests/tcg/cris/check_lz.c
>     tests/tcg/cris/check_openpf5.c
>     tests/tcg/cris/check_sigalrm.c
>     tests/tcg/cris/crisutils.h
>     tests/tcg/cris/sys.c
>     tests/tcg/i386/test-i386-ssse3.c
<snip>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


--
Alex Bennée

  parent reply	other threads:[~2018-12-14 14:02 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 22:37 [Qemu-devel] [PATCH 0/2] Fix TABs in many files Paolo Bonzini
2018-12-13 22:37 ` [Qemu-arm] [PATCH 1/2] remove space-tab sequences Paolo Bonzini
2018-12-13 22:37   ` [Qemu-devel] " Paolo Bonzini
2018-12-13 22:51   ` [Qemu-arm] " Richard Henderson
2018-12-13 22:51     ` [Qemu-devel] " Richard Henderson
2018-12-14  6:08   ` [Qemu-arm] " Markus Armbruster
2018-12-14  6:08     ` Markus Armbruster
2018-12-13 22:37 ` [PATCH 2/2] avoid TABs in files that only contain a few Paolo Bonzini
2018-12-13 22:37   ` [Qemu-devel] " Paolo Bonzini
2018-12-13 22:37   ` Paolo Bonzini
2018-12-13 22:52   ` Richard Henderson
2018-12-13 22:52   ` Richard Henderson
2018-12-13 22:52     ` [Qemu-devel] " Richard Henderson
2018-12-13 23:20   ` David Gibson
2018-12-13 23:20     ` [Qemu-devel] " David Gibson
2018-12-13 23:20   ` David Gibson
2018-12-14  1:33   ` Michael S. Tsirkin
2018-12-14  1:33     ` [Qemu-devel] " Michael S. Tsirkin
2018-12-14  1:33   ` Michael S. Tsirkin
2018-12-14 10:22   ` Daniel P. Berrangé
2018-12-14 10:22   ` Daniel P. Berrangé
2018-12-14 10:22     ` [Qemu-devel] " Daniel P. Berrangé
2018-12-14 11:35     ` Paolo Bonzini
2018-12-14 11:35       ` [Qemu-devel] " Paolo Bonzini
2018-12-14 11:35     ` Paolo Bonzini
2018-12-14 10:54   ` [SPAM] [Qemu-ppc] " Greg Kurz
2018-12-14 10:54     ` [Qemu-devel] " Greg Kurz
2018-12-14 10:54   ` Greg Kurz
2018-12-14 13:34   ` Peter Maydell
2018-12-14 13:34   ` Peter Maydell
2018-12-14 13:34     ` [Qemu-devel] " Peter Maydell
2018-12-14 14:02   ` Alex Bennée [this message]
2018-12-14 14:02     ` Alex Bennée
2018-12-14 14:02   ` Alex Bennée
2018-12-14 15:16   ` Stefan Hajnoczi
2018-12-14 15:16   ` Stefan Hajnoczi
2018-12-14 15:16     ` [Qemu-devel] " Stefan Hajnoczi
2018-12-14 15:17   ` Michael S. Tsirkin
2018-12-14 15:17     ` [Qemu-devel] " Michael S. Tsirkin
2018-12-14 15:17     ` Michael S. Tsirkin
2018-12-14 17:19   ` [Qemu-devel] " Aleksandar Markovic
2018-12-14 17:19   ` Aleksandar Markovic
2018-12-14 17:19     ` Aleksandar Markovic
2018-12-14 20:16   ` Eric Blake
2018-12-14 20:16   ` Eric Blake
2018-12-14 20:16     ` [Qemu-devel] " Eric Blake
2018-12-17  9:09   ` Stefan Markovic
2018-12-17  9:09   ` Stefan Markovic
2018-12-17  9:09     ` [Qemu-devel] " Stefan Markovic
2018-12-14 13:40 ` [Qemu-devel] [PATCH 0/2] Fix TABs in many files Wainer dos Santos Moschetta
2018-12-22 17:48 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imzw1a1v.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=amarkovic@wavecomp.com \
    --cc=amit@kernel.org \
    --cc=anthony.perard@citrix.com \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dmitry.fleytman@gmail.com \
    --cc=eblake@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=magnus.damm@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    --cc=smarkovic@wavecomp.com \
    --cc=sstabellini@kernel.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    --cc=viktor.prutyanov@phystech.edu \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.