All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Keith Packard" <keithp@keithp.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: mesa-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display
Date: Thu, 15 Feb 2018 12:26:57 -0800	[thread overview]
Message-ID: <87inayngmm.fsf@keithp.com> (raw)
In-Reply-To: <20180214121355.qs6k3jx4gt7lgpr6@imgtec.com>


[-- Attachment #1.1: Type: text/plain, Size: 1210 bytes --]

Eric Engestrom <eric.engestrom@imgtec.com> writes:

> Can be simplified a bit:
>
>   _xlib_lease = get_option('xlib-lease')
>   if _xlib_lease == 'auto'
>     with_xlib_lease = with_platform_x11 and with_platform_display
>   else
>     with_xlib_lease = _xlib_lease == 'true'
>   endif
>
> (We also usually try to avoid changing the type of a var, and meson might
> start being more strict with types in future releases)

I wondered about that in the places I copied my code from. Good to know
there's a better practice. I've switched to using this form.

>> +if with_xlib_lease
>> +  vulkan_wsi_deps += dep_xcb_xrandr
>> +  vulkan_wsi_args += [
>> +    '-DVK_USE_PLATFORM_XLIB_XRANDR_EXT',
>> +  ]
>
> vulkan_wsi_args += '-DVK_USE_PLATFORM_XLIB_XRANDR_EXT'

I switched all of the inappropriate usage to this form for six separate
patches (three each for core/anv/radv by two extensions (DISPLAY and XLIB_XRANDR).

> with that, the meson part of this is
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

Awesome!

Thanks for reviewing the build system bits; I'm just starting to use
meson and every new change is a learning opportunity at this point.

-- 
-keith

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

  reply	other threads:[~2018-02-15 20:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14  0:31 [PATCH 0/21] Add KHR_display through GOOGLE_display_timing [v2] Keith Packard
2018-02-14  0:31 ` [PATCH 01/21] vulkan: Add KHR_display extension using DRM Keith Packard
2018-02-24  0:43   ` Jason Ekstrand
2018-02-24  9:43     ` Daniel Stone
2018-03-07 20:28       ` [Mesa-dev] " Keith Packard
2018-03-07 20:15     ` Keith Packard
2018-02-14  0:31 ` [PATCH 02/21] anv: Add KHR_display extension to anv Keith Packard
2018-02-14  0:31 ` [PATCH 03/21] radv: Add KHR_display extension to radv Keith Packard
2018-02-14  0:31 ` [PATCH 04/21] vulkan: Add EXT_direct_mode_display Keith Packard
2018-02-14  0:31 ` [PATCH 05/21] anv: Add EXT_direct_mode_display to anv driver Keith Packard
2018-02-14  0:31 ` [PATCH 06/21] radv: Add EXT_direct_mode_display to radv driver Keith Packard
2018-02-14  0:31 ` [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display Keith Packard
2018-02-14 12:13   ` [Mesa-dev] " Eric Engestrom
2018-02-15 20:26     ` Keith Packard [this message]
2018-02-14  0:31 ` [PATCH 08/21] anv: Add EXT_acquire_xlib_display to anv driver Keith Packard
2018-02-14  0:31 ` [PATCH 09/21] radv: Add EXT_acquire_xlib_display to radv driver Keith Packard
2018-02-14  0:31 ` [PATCH 10/21] vulkan: Add VK_EXT_display_surface_counter [v3] Keith Packard
2018-02-14  0:31 ` [PATCH 11/21] anv: Add VK_EXT_display_surface_counter to anv driver [v4] Keith Packard
2018-02-14  0:31 ` [PATCH 12/21] radv: Add VK_EXT_display_surface_counter to radv driver Keith Packard
2018-02-14  0:31 ` [PATCH 13/21] vulkan: add VK_EXT_display_control [v3] Keith Packard
2018-02-14  0:31 ` [PATCH 14/21] anv: add VK_EXT_display_control to anv driver Keith Packard
2018-02-14  0:31 ` [PATCH 15/21] radv: add VK_EXT_display_control to radv driver Keith Packard
2018-02-14  0:31 ` [PATCH 16/21] vulkan: Define new VK_MESA_query_timestamp extension Keith Packard
2018-02-14  0:31 ` [PATCH 17/21] anv: Add new VK_MESA_query_timestamp extension to anv driver Keith Packard
2018-02-14  0:31 ` [PATCH 18/21] radv: Add new VK_MESA_query_timestamp extension to radv driver Keith Packard
2018-02-14  0:31 ` [PATCH 19/21] vulkan: Add VK_GOOGLE_display_timing extension (x11 and display backends) Keith Packard
2018-02-14  0:31 ` [PATCH 20/21] anv: Add VK_GOOGLE_display_timing extension to anv driver Keith Packard
2018-02-14  0:31 ` [PATCH 21/21] radv: Add VK_GOOGLE_display_timing extension to radv driver Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inayngmm.fsf@keithp.com \
    --to=keithp@keithp.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric.engestrom@imgtec.com \
    --cc=mesa-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.