From: Eric Anholt <eric@anholt.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Mark Brown <broonie@kernel.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: Re: [PATCH] spi: bcm2835aux: use 64-bit arithmetic instead of 32-bit
Date: Thu, 08 Feb 2018 08:22:54 +0000 [thread overview]
Message-ID: <87inb7c2ld.fsf@anholt.net> (raw)
In-Reply-To: <20180207160002.GA9292@embeddedgus>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> Add suffix ULL to constant 9 in order to give the compiler complete
> information about the proper arithmetic to use. Notice that this
> constant is used in a context that expects an expression of type
> unsigned long long (64 bits, unsigned).
>
> The expression tfr->len * 9 * 1000000 is currently being evaluated
> using 32-bit arithmetic.
>
> Addresses-Coverity-ID: 1339619
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
The effect looks like it would be that we would have chosen polling mode
instead of waiting for interrupts for some transfers >477 seconds.
Seems like a good fix for an unlikely bug.
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: bcm2835aux: use 64-bit arithmetic instead of 32-bit
Date: Thu, 08 Feb 2018 08:22:54 +0000 [thread overview]
Message-ID: <87inb7c2ld.fsf@anholt.net> (raw)
In-Reply-To: <20180207160002.GA9292@embeddedgus>
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> Add suffix ULL to constant 9 in order to give the compiler complete
> information about the proper arithmetic to use. Notice that this
> constant is used in a context that expects an expression of type
> unsigned long long (64 bits, unsigned).
>
> The expression tfr->len * 9 * 1000000 is currently being evaluated
> using 32-bit arithmetic.
>
> Addresses-Coverity-ID: 1339619
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
The effect looks like it would be that we would have chosen polling mode
instead of waiting for interrupts for some transfers >477 seconds.
Seems like a good fix for an unlikely bug.
Reviewed-by: Eric Anholt <eric@anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180208/e27ae2aa/attachment.sig>
next prev parent reply other threads:[~2018-02-08 8:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 16:00 [PATCH] spi: bcm2835aux: use 64-bit arithmetic instead of 32-bit Gustavo A. R. Silva
2018-02-07 16:00 ` Gustavo A. R. Silva
2018-02-08 8:22 ` Eric Anholt [this message]
2018-02-08 8:22 ` Eric Anholt
2018-02-12 17:57 ` Gustavo A. R. Silva
2018-02-12 17:57 ` Gustavo A. R. Silva
2018-02-08 9:54 ` Ard Biesheuvel
2018-02-08 9:54 ` Ard Biesheuvel
2018-02-08 9:54 ` Ard Biesheuvel
2018-02-12 18:04 ` Gustavo A. R. Silva
2018-02-12 18:04 ` Gustavo A. R. Silva
2018-02-12 18:45 ` Ard Biesheuvel
2018-02-12 18:45 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9VTkNN-6MCCuQ2jWFyDMeZKNRyPqMpTWB5jvuSw7MWeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-12 19:10 ` Florian Fainelli
2018-02-12 19:10 ` Florian Fainelli
2018-02-12 19:10 ` Florian Fainelli
[not found] ` <bab99bbb-c84b-3413-e7f8-203c7daad8b3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-12 19:11 ` Ard Biesheuvel
2018-02-12 19:11 ` Ard Biesheuvel
2018-02-12 19:11 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9Mb7Wpzwvr=1WsUs1jXYT16DL2dYBfhSWH0HYZMYM5Nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-12 19:14 ` Florian Fainelli
2018-02-12 19:14 ` Florian Fainelli
2018-02-12 19:14 ` Florian Fainelli
2018-02-12 19:31 ` Trent Piepho
2018-02-12 19:31 ` Trent Piepho
2018-02-12 19:31 ` Trent Piepho
2018-02-12 19:38 ` [PATCH] spi: bcm2835aux: Avoid 64-bit arithmetic in xfer len calc Trent Piepho
2018-02-12 19:38 ` Trent Piepho
[not found] ` <20180212193814.17644-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2018-02-14 16:04 ` Mark Brown
2018-02-14 16:04 ` Mark Brown
2018-02-14 16:04 ` Mark Brown
2018-02-14 16:28 ` Applied "spi: bcm2835aux: Avoid 64-bit arithmetic in xfer len calc" to the spi tree Mark Brown
2018-02-14 16:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inb7c2ld.fsf@anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.