From: Felipe Balbi <balbi@kernel.org>
To: Rob Herring <robh@kernel.org>, Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
John Youn <John.Youn@synopsys.com>
Subject: [14/15] usb: dwc3: Add disabling of start_transfer failure quirk
Date: Tue, 09 Jan 2018 10:45:01 +0200 [thread overview]
Message-ID: <87incbzaia.fsf@linux.intel.com> (raw)
Hi,
Rob Herring <robh@kernel.org> writes:
> On Fri, Jan 05, 2018 at 12:16:02PM -0800, Thinh Nguyen wrote:
>> In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc
>> START TRANSFER command failure. However, some affected versions may have
>> RTL patches to fix this without a SW workaround. Add this quirk to
>> disable the SW workaround when it is not needed.
>
> I really think this one should be implied by compatible strings.
won't work for dwc3. Core driver has a single compatible string, also
this wouldn't work for PCI-based implementations.
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Thinh Nguyen
<Thinh.Nguyen-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 14/15] usb: dwc3: Add disabling of start_transfer failure quirk
Date: Tue, 09 Jan 2018 10:45:01 +0200 [thread overview]
Message-ID: <87incbzaia.fsf@linux.intel.com> (raw)
In-Reply-To: <20180109041602.f4tk5jynnno2xgvk@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hi,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:
> On Fri, Jan 05, 2018 at 12:16:02PM -0800, Thinh Nguyen wrote:
>> In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc
>> START TRANSFER command failure. However, some affected versions may have
>> RTL patches to fix this without a SW workaround. Add this quirk to
>> disable the SW workaround when it is not needed.
>
> I really think this one should be implied by compatible strings.
won't work for dwc3. Core driver has a single compatible string, also
this wouldn't work for PCI-based implementations.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next reply other threads:[~2018-01-09 8:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 8:45 Felipe Balbi [this message]
2018-01-09 8:45 ` [PATCH 14/15] usb: dwc3: Add disabling of start_transfer failure quirk Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-01-11 14:35 [14/15] " Rob Herring
2018-01-11 14:35 ` [PATCH 14/15] " Rob Herring
2018-01-09 23:54 [08/15] usb: dwc3: Make RX/TX threshold configurable Thinh Nguyen
2018-01-09 23:54 ` [PATCH 08/15] " Thinh Nguyen
2018-01-09 4:16 [14/15] usb: dwc3: Add disabling of start_transfer failure quirk Rob Herring
2018-01-09 4:16 ` [PATCH 14/15] " Rob Herring
2018-01-09 4:12 [08/15] usb: dwc3: Make RX/TX threshold configurable Rob Herring
2018-01-09 4:12 ` [PATCH 08/15] " Rob Herring
2018-01-05 20:16 [14/15] usb: dwc3: Add disabling of start_transfer failure quirk Thinh Nguyen
2018-01-05 20:16 ` [PATCH 14/15] " Thinh Nguyen
2018-01-05 20:14 [08/15] usb: dwc3: Make RX/TX threshold configurable Thinh Nguyen
2018-01-05 20:14 ` [PATCH 08/15] " Thinh Nguyen
2018-01-05 20:13 [PATCH 00/15] usb: dwc3: Add new updates for DWC_usb31 Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87incbzaia.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.