All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
To: Tetsuo Handa
	<penguin-kernel-JPay3/Yim36HaxMnTkn67Xf5DAMn2ifp@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 1/2] mm: add sysctl to control global OOM logging behaviour
Date: Wed, 08 Nov 2017 15:19:50 +0300	[thread overview]
Message-ID: <87inelklnd.fsf@openvz.org> (raw)
In-Reply-To: <24fb6865-6cc5-2af0-3a99-ea9495791f66-JPay3/Yim36HaxMnTkn67Xf5DAMn2ifp@public.gmane.org>

Tetsuo Handa <penguin-kernel-JPay3/Yim36HaxMnTkn67Xf5DAMn2ifp@public.gmane.org> writes:

> On 2017/11/08 18:18, Dmitry Monakhov wrote:
>> Our systems becomes bigger and bigger, but OOM still happens.
>> This becomes serious problem for systems where OOM happens
>> frequently(containers, VM) because each OOM generate pressure
>> on dmesg log infrastructure. Let's allow system administrator
>> ability to tune OOM dump behaviour
>
> Majority of OOM killer related messages are from dump_header().
> Thus, allow tuning __ratelimit(&oom_rs) might make sense.
>
> But other lines
>
>   "%s: Kill process %d (%s) score %u or sacrifice child\n"
>   "Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB\n"
>   "oom_reaper: reaped process %d (%s), now anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB\n"
This still may result in hundreds of messages per second.
So it would be nice to have option to disable OOM logging.
> should not cause problems, for it is easy to exclude such lines from
> your dmesg log infrastructure using fgrep match.
In fact I've considered an abbility to use even more
fine grained log level control:
0: no oom log at all
1: dump only single line logs ( from oom_kill_process and reaper_task)
2: 1+ dump headers
3: 2+ task_stack (which previously controlled by sysctl_oom_dump_task)
What do you think?
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo-Bw31MaZKKs0EbZ0PF+XxCw@public.gmane.org  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"> email-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Monakhov <dmonakhov@openvz.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, linux-mm@kvack.org
Cc: cgroups@vger.kernel.org, vdavydov.dev@gmail.com
Subject: Re: [PATCH 1/2] mm: add sysctl to control global OOM logging behaviour
Date: Wed, 08 Nov 2017 15:19:50 +0300	[thread overview]
Message-ID: <87inelklnd.fsf@openvz.org> (raw)
In-Reply-To: <24fb6865-6cc5-2af0-3a99-ea9495791f66@I-love.SAKURA.ne.jp>

Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> writes:

> On 2017/11/08 18:18, Dmitry Monakhov wrote:
>> Our systems becomes bigger and bigger, but OOM still happens.
>> This becomes serious problem for systems where OOM happens
>> frequently(containers, VM) because each OOM generate pressure
>> on dmesg log infrastructure. Let's allow system administrator
>> ability to tune OOM dump behaviour
>
> Majority of OOM killer related messages are from dump_header().
> Thus, allow tuning __ratelimit(&oom_rs) might make sense.
>
> But other lines
>
>   "%s: Kill process %d (%s) score %u or sacrifice child\n"
>   "Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB\n"
>   "oom_reaper: reaped process %d (%s), now anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB\n"
This still may result in hundreds of messages per second.
So it would be nice to have option to disable OOM logging.
> should not cause problems, for it is easy to exclude such lines from
> your dmesg log infrastructure using fgrep match.
In fact I've considered an abbility to use even more
fine grained log level control:
0: no oom log at all
1: dump only single line logs ( from oom_kill_process and reaper_task)
2: 1+ dump headers
3: 2+ task_stack (which previously controlled by sysctl_oom_dump_task)
What do you think?
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-11-08 12:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  9:18 [PATCH 1/2] mm: add sysctl to control global OOM logging behaviour Dmitry Monakhov
     [not found] ` <20171108091843.29349-1-dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2017-11-08  9:18   ` [PATCH 2/2] mm: memcg control oom logging behavior Dmitry Monakhov
2017-11-08  9:18     ` Dmitry Monakhov
2017-11-08 11:42 ` [PATCH 1/2] mm: add sysctl to control global OOM logging behaviour Tetsuo Handa
     [not found]   ` <24fb6865-6cc5-2af0-3a99-ea9495791f66-JPay3/Yim36HaxMnTkn67Xf5DAMn2ifp@public.gmane.org>
2017-11-08 12:19     ` Dmitry Monakhov [this message]
2017-11-08 12:19       ` Dmitry Monakhov
2017-11-08 13:45       ` Tetsuo Handa
2017-11-09 12:56 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inelklnd.fsf@openvz.org \
    --to=dmonakhov-gefaqzzx7r8dnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=penguin-kernel-JPay3/Yim36HaxMnTkn67Xf5DAMn2ifp@public.gmane.org \
    --cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.