* aac_convert_sgraw2() masks -ENOMEM
@ 2017-08-08 10:58 Nikola Pajkovsky
0 siblings, 0 replies; only message in thread
From: Nikola Pajkovsky @ 2017-08-08 10:58 UTC (permalink / raw)
To: Adaptec OEM Raid Solutions
Cc: linux-scsi, James E.J. Bottomley, Martin K. Petersen
Hey,
today, I have run smatch and it reports, that aac_convert_sgraw2()
returns -1 instead of -ENOMEM on kmalloc(). This is easy to fix, but
nobody tests what aac_convert_sgraw2() returns in aac_build_sgraw2()
Since commit 0b4334473d48 ("[SCSI] aacraid: SCSI dma mapping failure
case handling"), aac_build_sgraw2() should have better error propagation
in aac_{read,write}_raw_io().
The question is, that if it's intentional (and I hope it's not) or it's
just leftover fix?
--
Nikola
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-08 10:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 10:58 aac_convert_sgraw2() masks -ENOMEM Nikola Pajkovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.