From: balbi@kernel.org (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-next v2 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme
Date: Fri, 27 Jan 2017 11:07:53 +0200 [thread overview]
Message-ID: <87inp098gm.fsf@linux.intel.com> (raw)
In-Reply-To: <84fe6fa4-7cf7-22cb-b4b7-47e2cb202a68@atmel.com>
Nicolas Ferre <nicolas.ferre@atmel.com> writes:
> Le 23/01/2017 ? 15:45, cristian.birsan at microchip.com a ?crit :
>> From: Cristian Birsan <cristian.birsan@microchip.com>
>>
>> Update atmel udc driver with a new enpoint allocation scheme. The data
>> sheet requires that all endpoints are allocated in order.
>
> Pieces of information from the cover letter could have been added here.
yup, that's what I did:
commit 741d2558bf0aa8da9c0834ad43e1b9a1b16aa515
Author: Cristian Birsan <cristian.birsan@microchip.com>
Date: Mon Jan 23 16:45:59 2017 +0200
usb: gadget: udc: atmel: Update endpoint allocation scheme
This patch updates the usb endpoint allocation scheme for atmel usba
driver to make sure all endpoints are allocated in order. This
requirement comes from the datasheet of the controller.
The allocation scheme is decided by fifo_mode parameter. For fifo_mode =
0 the driver tries to autoconfigure the endpoints fifo size. All other
modes contain fixed configurations optimized for different purposes. The
idea is somehow similar with the approach used on musb driver.
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
But seems like we will need a fixup patch during v4.11-rc?
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170127/2e9ab65b/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>,
cristian.birsan@microchip.com, gregkh@linuxfoundation.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ludovic.desroches@atmel.com,
alexandre.belloni@free-electrons.com,
boris.brezillon@free-electrons.com
Subject: Re: [PATCH linux-next v2 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme
Date: Fri, 27 Jan 2017 11:07:53 +0200 [thread overview]
Message-ID: <87inp098gm.fsf@linux.intel.com> (raw)
In-Reply-To: <84fe6fa4-7cf7-22cb-b4b7-47e2cb202a68@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
Nicolas Ferre <nicolas.ferre@atmel.com> writes:
> Le 23/01/2017 à 15:45, cristian.birsan@microchip.com a écrit :
>> From: Cristian Birsan <cristian.birsan@microchip.com>
>>
>> Update atmel udc driver with a new enpoint allocation scheme. The data
>> sheet requires that all endpoints are allocated in order.
>
> Pieces of information from the cover letter could have been added here.
yup, that's what I did:
commit 741d2558bf0aa8da9c0834ad43e1b9a1b16aa515
Author: Cristian Birsan <cristian.birsan@microchip.com>
Date: Mon Jan 23 16:45:59 2017 +0200
usb: gadget: udc: atmel: Update endpoint allocation scheme
This patch updates the usb endpoint allocation scheme for atmel usba
driver to make sure all endpoints are allocated in order. This
requirement comes from the datasheet of the controller.
The allocation scheme is decided by fifo_mode parameter. For fifo_mode =
0 the driver tries to autoconfigure the endpoints fifo size. All other
modes contain fixed configurations optimized for different purposes. The
idea is somehow similar with the approach used on musb driver.
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
But seems like we will need a fixup patch during v4.11-rc?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-01-27 9:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 14:45 [PATCH linux-next v2 0/1] usb: gadget: udc: atmel: Update endpoint allocation scheme cristian.birsan at microchip.com
2017-01-23 14:45 ` cristian.birsan
2017-01-23 14:45 ` [PATCH linux-next v2 1/1] " cristian.birsan at microchip.com
2017-01-23 14:45 ` cristian.birsan
2017-01-26 15:02 ` Nicolas Ferre
2017-01-26 15:02 ` Nicolas Ferre
2017-01-27 9:07 ` Felipe Balbi [this message]
2017-01-27 9:07 ` Felipe Balbi
2017-01-27 13:47 ` Cristian Birsan
2017-01-27 13:47 ` Cristian Birsan
2017-01-27 14:56 ` Nicolas Ferre
2017-01-27 14:56 ` Nicolas Ferre
2017-01-27 15:01 ` Felipe Balbi
2017-01-27 15:01 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inp098gm.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.