From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v3 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts
Date: Fri, 20 Jan 2017 08:42:11 +0100 [thread overview]
Message-ID: <87inpadvos.fsf@belgarion.home> (raw)
In-Reply-To: <e692c4a9-6320-b9e0-d6e7-f58bbe6ba867@siemens.com> (Jan Kiszka's message of "Thu, 19 Jan 2017 20:37:40 +0100")
Jan Kiszka <jan.kiszka@siemens.com> writes:
> When using the a device with edge-triggered interrupts, such as MSIs,
> the interrupt handler has to ensure that there is a point in time during
> its execution where all interrupts sources are silent so that a new
> event can trigger a new interrupt again.
>
> This is achieved here by disabling all interrupt sources for a moment
> before processing them according to the status register. If a new
> interrupt should have arrived after we read the status, it will now
> re-trigger the interrupt, even in edge mode.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts
Date: Fri, 20 Jan 2017 08:42:11 +0100 [thread overview]
Message-ID: <87inpadvos.fsf@belgarion.home> (raw)
In-Reply-To: <e692c4a9-6320-b9e0-d6e7-f58bbe6ba867@siemens.com> (Jan Kiszka's message of "Thu, 19 Jan 2017 20:37:40 +0100")
Jan Kiszka <jan.kiszka@siemens.com> writes:
> When using the a device with edge-triggered interrupts, such as MSIs,
> the interrupt handler has to ensure that there is a point in time during
> its execution where all interrupts sources are silent so that a new
> event can trigger a new interrupt again.
>
> This is achieved here by disabling all interrupt sources for a moment
> before processing them according to the status register. If a new
> interrupt should have arrived after we read the status, it will now
> re-trigger the interrupt, even in edge mode.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v3 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts
Date: Fri, 20 Jan 2017 08:42:11 +0100 [thread overview]
Message-ID: <87inpadvos.fsf@belgarion.home> (raw)
In-Reply-To: <e692c4a9-6320-b9e0-d6e7-f58bbe6ba867@siemens.com> (Jan Kiszka's message of "Thu, 19 Jan 2017 20:37:40 +0100")
Jan Kiszka <jan.kiszka@siemens.com> writes:
> When using the a device with edge-triggered interrupts, such as MSIs,
> the interrupt handler has to ensure that there is a point in time during
> its execution where all interrupts sources are silent so that a new
> event can trigger a new interrupt again.
>
> This is achieved here by disabling all interrupt sources for a moment
> before processing them according to the status register. If a new
> interrupt should have arrived after we read the status, it will now
> re-trigger the interrupt, even in edge mode.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
next prev parent reply other threads:[~2017-01-20 7:42 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 18:44 [PATCH v2 0/3] spi: pca2xx: Prepare for and enable MSI support Jan Kiszka
2017-01-16 18:44 ` Jan Kiszka
2017-01-16 18:44 ` Jan Kiszka
2017-01-16 18:44 ` [PATCH v2 1/3] spi: pxa2xx: Factor out handle_bad_msg Jan Kiszka
2017-01-16 18:44 ` Jan Kiszka
2017-01-16 18:44 ` Jan Kiszka
[not found] ` <776c72d3de4b75ff0a8b91791740389950d8abe8.1484592296.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2017-01-17 11:18 ` Jarkko Nikula
2017-01-17 11:18 ` Jarkko Nikula
2017-01-17 11:18 ` Jarkko Nikula
2017-01-17 18:46 ` Applied "spi: pxa2xx: Factor out handle_bad_msg" to the spi tree Mark Brown
2017-01-17 18:46 ` Mark Brown
2017-01-17 18:46 ` Mark Brown
2017-01-16 18:44 ` [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts Jan Kiszka
2017-01-16 18:44 ` Jan Kiszka
[not found] ` <7b15a0910a3ad861fd32161c72559bafa7b71e29.1484592296.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2017-01-16 19:07 ` Andy Shevchenko
2017-01-16 19:07 ` Andy Shevchenko
2017-01-16 19:07 ` Andy Shevchenko
[not found] ` <1484593637.2133.152.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-01-16 19:46 ` Jan Kiszka
2017-01-16 19:46 ` Jan Kiszka
2017-01-16 19:46 ` Jan Kiszka
2017-01-17 18:52 ` Jan Kiszka
2017-01-17 18:52 ` Jan Kiszka
2017-01-17 18:52 ` Jan Kiszka
2017-01-17 7:54 ` Robert Jarzmik
2017-01-17 7:54 ` Robert Jarzmik
2017-01-17 7:54 ` Robert Jarzmik
2017-01-17 8:05 ` Jan Kiszka
2017-01-17 8:05 ` Jan Kiszka
2017-01-17 8:05 ` Jan Kiszka
2017-01-18 8:21 ` Robert Jarzmik
2017-01-18 8:21 ` Robert Jarzmik
2017-01-18 8:21 ` Robert Jarzmik
2017-01-18 9:33 ` Jan Kiszka
2017-01-18 9:33 ` Jan Kiszka
2017-01-18 9:33 ` Jan Kiszka
2017-01-18 12:46 ` Mark Brown
2017-01-18 12:46 ` Mark Brown
2017-01-19 15:34 ` Jan Kiszka
2017-01-19 15:34 ` Jan Kiszka
2017-01-19 15:34 ` Jan Kiszka
2017-01-19 19:37 ` [PATCH v3 " Jan Kiszka
2017-01-19 19:37 ` Jan Kiszka
2017-01-19 19:37 ` Jan Kiszka
2017-01-19 19:57 ` Mark Brown
2017-01-19 19:57 ` Mark Brown
2017-01-19 19:57 ` Mark Brown
[not found] ` <20170119195701.kueutgmahr6bmxhq-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-01-19 20:04 ` Andy Shevchenko
2017-01-19 20:04 ` Andy Shevchenko
2017-01-19 20:04 ` Andy Shevchenko
2017-01-20 12:21 ` Mark Brown
2017-01-20 12:21 ` Mark Brown
2017-01-20 15:29 ` Jan Kiszka
2017-01-20 15:29 ` Jan Kiszka
2017-01-20 15:29 ` Jan Kiszka
2017-01-20 16:14 ` Mark Brown
2017-01-20 16:14 ` Mark Brown
2017-01-20 16:14 ` Mark Brown
2017-01-20 7:42 ` Robert Jarzmik [this message]
2017-01-20 7:42 ` Robert Jarzmik
2017-01-20 7:42 ` Robert Jarzmik
2017-01-24 18:39 ` Applied "spi: pxa2xx: Prepare for edge-triggered interrupts" to the spi tree Mark Brown
2017-01-24 18:39 ` Mark Brown
2017-01-17 7:58 ` [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts Robert Jarzmik
2017-01-17 7:58 ` Robert Jarzmik
2017-01-17 7:58 ` Robert Jarzmik
2017-01-17 8:10 ` Jan Kiszka
2017-01-17 8:10 ` Jan Kiszka
2017-01-17 8:10 ` Jan Kiszka
2017-01-17 13:11 ` Jarkko Nikula
2017-01-17 13:11 ` Jarkko Nikula
2017-01-17 14:43 ` Jan Kiszka
2017-01-17 14:43 ` Jan Kiszka
2017-01-17 14:43 ` Jan Kiszka
2017-01-16 18:44 ` [PATCH v2 3/3] spi: pca2xx-pci: Allow MSI Jan Kiszka
2017-01-16 18:44 ` Jan Kiszka
2017-01-16 18:44 ` Jan Kiszka
[not found] ` <9f5bc54a5842b383dc81fa8586d6774c03d2c452.1484592296.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2017-01-16 19:08 ` Andy Shevchenko
2017-01-16 19:08 ` Andy Shevchenko
2017-01-16 19:08 ` Andy Shevchenko
2017-01-17 11:18 ` Jarkko Nikula
2017-01-17 11:18 ` Jarkko Nikula
2017-01-24 18:39 ` Applied "spi: pca2xx-pci: Allow MSI" to the spi tree Mark Brown
2017-01-24 18:39 ` Mark Brown
2017-01-24 18:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inpadvos.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sascha.weisenberger@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.