Re: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code

[Stewart Smith <stewart@linux.vnet.ibm.com>]

OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:

> From: Norman James <njames@us.ibm.com>
>
> This function uses static data and should always
> return a good return code.  This was causing OCC
> not to start.
>
> Signed-off-by: Norman James <nkskjames@gmail.com>
> ---
>  dcmihandler.C | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/dcmihandler.C b/dcmihandler.C
> index fafebdc..5e7d879 100644
> --- a/dcmihandler.C
> +++ b/dcmihandler.C
> @@ -11,7 +11,7 @@ ipmi_ret_t ipmi_dcmi_get_power_limit(ipmi_netfn_t netfn, ipmi_cmd_t cmd,
>                                ipmi_request_t request, ipmi_response_t response, 
>                                ipmi_data_len_t data_len, ipmi_context_t context)
>  {
> -    ipmi_ret_t rc = IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT;
> +    ipmi_ret_t rc = 0;
>  
>      // dcmi-v1-5-rev-spec.pdf 6.6.2.

Shouldn't the value of rc be something that is an ipmi_ret_t ?

>      // This is good enough for OpenBMC support for OpenPOWER based systems
> @@ -37,4 +37,3 @@ void register_netfn_dcmi_functions()
>      ipmi_register_callback(NETFUN_GRPEXT, IPMI_CMD_DCMI_GET_POWER, NULL, ipmi_dcmi_get_power_limit);
>      return;
>  }
> -// 956379
> \ No newline at end of file

Above hunk is irrelevant.

-- 
Stewart Smith
OPAL Architect, IBM.