* [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code @ 2016-03-08 16:10 OpenBMC Patches 2016-03-08 16:10 ` OpenBMC Patches 0 siblings, 1 reply; 6+ messages in thread From: OpenBMC Patches @ 2016-03-08 16:10 UTC (permalink / raw) To: openbmc; +Cc: Norman James This function uses static data and should always return a good return code. This was causing OCC not to start. Signed-off-by: Norman James <nkskjames@gmail.com> https://github.com/openbmc/phosphor-host-ipmid/pull/73 Norman James (1): DCMI GET_POWER_LEVEL bad return code dcmihandler.C | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.7.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code 2016-03-08 16:10 [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code OpenBMC Patches @ 2016-03-08 16:10 ` OpenBMC Patches 2016-03-08 17:33 ` Chris Austen 2016-03-09 5:25 ` Stewart Smith 0 siblings, 2 replies; 6+ messages in thread From: OpenBMC Patches @ 2016-03-08 16:10 UTC (permalink / raw) To: openbmc; +Cc: Norman James, Norman James From: Norman James <njames@us.ibm.com> This function uses static data and should always return a good return code. This was causing OCC not to start. Signed-off-by: Norman James <nkskjames@gmail.com> --- dcmihandler.C | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dcmihandler.C b/dcmihandler.C index fafebdc..5e7d879 100644 --- a/dcmihandler.C +++ b/dcmihandler.C @@ -11,7 +11,7 @@ ipmi_ret_t ipmi_dcmi_get_power_limit(ipmi_netfn_t netfn, ipmi_cmd_t cmd, ipmi_request_t request, ipmi_response_t response, ipmi_data_len_t data_len, ipmi_context_t context) { - ipmi_ret_t rc = IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT; + ipmi_ret_t rc = 0; // dcmi-v1-5-rev-spec.pdf 6.6.2. // This is good enough for OpenBMC support for OpenPOWER based systems @@ -37,4 +37,3 @@ void register_netfn_dcmi_functions() ipmi_register_callback(NETFUN_GRPEXT, IPMI_CMD_DCMI_GET_POWER, NULL, ipmi_dcmi_get_power_limit); return; } -// 956379 \ No newline at end of file -- 2.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code 2016-03-08 16:10 ` OpenBMC Patches @ 2016-03-08 17:33 ` Chris Austen 2016-03-09 5:25 ` Stewart Smith 1 sibling, 0 replies; 6+ messages in thread From: Chris Austen @ 2016-03-08 17:33 UTC (permalink / raw) To: openbmc-patches; +Cc: nkskjames, openbmc [-- Attachment #1: Type: text/html, Size: 3113 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code 2016-03-08 16:10 ` OpenBMC Patches 2016-03-08 17:33 ` Chris Austen @ 2016-03-09 5:25 ` Stewart Smith 2016-03-09 5:50 ` Norman James 2016-03-09 5:54 ` Vishwanatha Subbanna 1 sibling, 2 replies; 6+ messages in thread From: Stewart Smith @ 2016-03-09 5:25 UTC (permalink / raw) To: OpenBMC Patches, openbmc; +Cc: Norman James OpenBMC Patches <openbmc-patches@stwcx.xyz> writes: > From: Norman James <njames@us.ibm.com> > > This function uses static data and should always > return a good return code. This was causing OCC > not to start. > > Signed-off-by: Norman James <nkskjames@gmail.com> > --- > dcmihandler.C | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/dcmihandler.C b/dcmihandler.C > index fafebdc..5e7d879 100644 > --- a/dcmihandler.C > +++ b/dcmihandler.C > @@ -11,7 +11,7 @@ ipmi_ret_t ipmi_dcmi_get_power_limit(ipmi_netfn_t netfn, ipmi_cmd_t cmd, > ipmi_request_t request, ipmi_response_t response, > ipmi_data_len_t data_len, ipmi_context_t context) > { > - ipmi_ret_t rc = IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT; > + ipmi_ret_t rc = 0; > > // dcmi-v1-5-rev-spec.pdf 6.6.2. Shouldn't the value of rc be something that is an ipmi_ret_t ? > // This is good enough for OpenBMC support for OpenPOWER based systems > @@ -37,4 +37,3 @@ void register_netfn_dcmi_functions() > ipmi_register_callback(NETFUN_GRPEXT, IPMI_CMD_DCMI_GET_POWER, NULL, ipmi_dcmi_get_power_limit); > return; > } > -// 956379 > \ No newline at end of file Above hunk is irrelevant. -- Stewart Smith OPAL Architect, IBM. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code 2016-03-09 5:25 ` Stewart Smith @ 2016-03-09 5:50 ` Norman James 2016-03-09 5:54 ` Vishwanatha Subbanna 1 sibling, 0 replies; 6+ messages in thread From: Norman James @ 2016-03-09 5:50 UTC (permalink / raw) To: Stewart Smith; +Cc: OpenBMC Patches, openbmc I canceled this pull request. Sent from my iPhone > On Mar 8, 2016, at 9:25 PM, Stewart Smith <stewart@linux.vnet.ibm.com> wrote: > > OpenBMC Patches <openbmc-patches@stwcx.xyz> writes: > >> From: Norman James <njames@us.ibm.com> >> >> This function uses static data and should always >> return a good return code. This was causing OCC >> not to start. >> >> Signed-off-by: Norman James <nkskjames@gmail.com> >> --- >> dcmihandler.C | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/dcmihandler.C b/dcmihandler.C >> index fafebdc..5e7d879 100644 >> --- a/dcmihandler.C >> +++ b/dcmihandler.C >> @@ -11,7 +11,7 @@ ipmi_ret_t ipmi_dcmi_get_power_limit(ipmi_netfn_t netfn, ipmi_cmd_t cmd, >> ipmi_request_t request, ipmi_response_t response, >> ipmi_data_len_t data_len, ipmi_context_t context) >> { >> - ipmi_ret_t rc = IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT; >> + ipmi_ret_t rc = 0; >> >> // dcmi-v1-5-rev-spec.pdf 6.6.2. > > Shouldn't the value of rc be something that is an ipmi_ret_t ? > >> // This is good enough for OpenBMC support for OpenPOWER based systems >> @@ -37,4 +37,3 @@ void register_netfn_dcmi_functions() >> ipmi_register_callback(NETFUN_GRPEXT, IPMI_CMD_DCMI_GET_POWER, NULL, ipmi_dcmi_get_power_limit); >> return; >> } >> -// 956379 >> \ No newline at end of file > > Above hunk is irrelevant. > > -- > Stewart Smith > OPAL Architect, IBM. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code 2016-03-09 5:25 ` Stewart Smith 2016-03-09 5:50 ` Norman James @ 2016-03-09 5:54 ` Vishwanatha Subbanna 1 sibling, 0 replies; 6+ messages in thread From: Vishwanatha Subbanna @ 2016-03-09 5:54 UTC (permalink / raw) To: Stewart Smith; +Cc: OpenBMC Patches, openbmc, Norman James [-- Attachment #1.1: Type: text/plain, Size: 2440 bytes --] Shouldn't the value of rc be something that is an ipmi_ret_t ? Yes : It needs to be even though CC_OK and 0 are same. Thanks ------------------------------------------------------------------------------------- Thanks and Regards, Vishwanath. Advisory Software Engineer, Power Firmware Development, Systems &Technology Lab, MG2-6F-255 , Manyata Embassy Business Park, Bangalore , KA , 560045 Ph: +91-80-46678255 E-mail: vishwanath@in.ibm.com ---------------------------------------------------------------------------------- From: Stewart Smith <stewart@linux.vnet.ibm.com> To: OpenBMC Patches <openbmc-patches@stwcx.xyz>, openbmc@lists.ozlabs.org Cc: Norman James <nkskjames@gmail.com> Date: 09/03/2016 10:56 am Subject: Re: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code Sent by: "openbmc" <openbmc-bounces +vishwanath=in.ibm.com@lists.ozlabs.org> OpenBMC Patches <openbmc-patches@stwcx.xyz> writes: > From: Norman James <njames@us.ibm.com> > > This function uses static data and should always > return a good return code. This was causing OCC > not to start. > > Signed-off-by: Norman James <nkskjames@gmail.com> > --- > dcmihandler.C | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/dcmihandler.C b/dcmihandler.C > index fafebdc..5e7d879 100644 > --- a/dcmihandler.C > +++ b/dcmihandler.C > @@ -11,7 +11,7 @@ ipmi_ret_t ipmi_dcmi_get_power_limit(ipmi_netfn_t netfn, ipmi_cmd_t cmd, > ipmi_request_t request, ipmi_response_t response, > ipmi_data_len_t data_len, ipmi_context_t context) > { > - ipmi_ret_t rc = IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT; > + ipmi_ret_t rc = 0; > > // dcmi-v1-5-rev-spec.pdf 6.6.2. Shouldn't the value of rc be something that is an ipmi_ret_t ? > // This is good enough for OpenBMC support for OpenPOWER based systems > @@ -37,4 +37,3 @@ void register_netfn_dcmi_functions() > ipmi_register_callback(NETFUN_GRPEXT, IPMI_CMD_DCMI_GET_POWER, NULL, ipmi_dcmi_get_power_limit); > return; > } > -// 956379 > \ No newline at end of file Above hunk is irrelevant. -- Stewart Smith OPAL Architect, IBM. _______________________________________________ openbmc mailing list openbmc@lists.ozlabs.org https://lists.ozlabs.org/listinfo/openbmc [-- Attachment #1.2: Type: text/html, Size: 3984 bytes --] [-- Attachment #2: graycol.gif --] [-- Type: image/gif, Size: 105 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-09 5:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-08 16:10 [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code OpenBMC Patches 2016-03-08 16:10 ` OpenBMC Patches 2016-03-08 17:33 ` Chris Austen 2016-03-09 5:25 ` Stewart Smith 2016-03-09 5:50 ` Norman James 2016-03-09 5:54 ` Vishwanatha Subbanna
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.
![[-- Attachment #2: graycol.gif --] [-- Type: image/gif, Size: 105 bytes --]](../../201603090554.u295sMrT21365036@d28relay05.in.ibm.com/2-graycol.gif){kind=link}