All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: andrew@aj.id.au, OpenBMC Patches <openbmc-patches@stwcx.xyz>,
	openbmc@lists.ozlabs.org
Subject: Re: [PATCH phosphor-host-ipmid v2] IPMI Get IP Support
Date: Thu, 11 Feb 2016 16:36:18 +1100	[thread overview]
Message-ID: <87io1vq04t.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455152677.3153.81.camel@aj.id.au>

Andrew Jeffery <andrew@aj.id.au> writes:
> I realise this has already been merged, but I feel like I should point
> out some issues below for future improvements.

Perhaps unreviewed code shouldn't be merged. Especially considering that
there's been so many comments on so many patches in this project.

-- 
Stewart Smith
OPAL Architect, IBM.

  reply	other threads:[~2016-02-11  5:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 21:40 [PATCH phosphor-host-ipmid v2] IPMI Get IP Support OpenBMC Patches
2016-02-10 21:40 ` OpenBMC Patches
2016-02-11  1:04   ` Andrew Jeffery
2016-02-11  5:36     ` Stewart Smith [this message]
2016-02-11  5:44       ` Chris Austen
     [not found]     ` <201602110544.u1B5il3T028608@d01av04.pok.ibm.com>
2016-02-11  6:26       ` Andrew Jeffery
     [not found]     ` <201602110544.u1B5ilIu004589@d03av01.boulder.ibm.com>
2016-02-11 21:15       ` Stewart Smith
2016-02-11 23:09         ` Andrew Jeffery
2016-02-12  3:12           ` Chris Austen
2016-02-12  3:28           ` Jeremy Kerr
2016-02-16  7:35             ` Stewart Smith
     [not found] <201602120312.u1C3CHwh000341@d01av01.pok.ibm.com>
2016-02-16  7:33 ` Stewart Smith
     [not found] <201602120308.u1C38vNo004937@d01av05.pok.ibm.com>
2016-02-16 23:45 ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io1vq04t.fsf@linux.vnet.ibm.com \
    --to=stewart@linux.vnet.ibm.com \
    --cc=andrew@aj.id.au \
    --cc=openbmc-patches@stwcx.xyz \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.