Re: [PATCH phosphor-host-ipmid v2] IPMI Get IP Support

[Stewart Smith <stewart@linux.vnet.ibm.com>]

Chris Austen <austenc@us.ibm.com> writes:
> Open an issue to migrate to inet_pton.

Fixing such things in code review is a much better approach.

For the submitter, it helps get quick feedback on tehir code, and
promotes a culture of examining your own code closely for things before
submitting it.

For maintainers and those who hare going to have to debug the systems,
it means that it's *very* quick and cheap (in time) to point out odd
things.

Opening issues is approximately an order of magnitude slower.

I can hit reply, type ten words and hit send in maybe a few seconds. For
an issue, you're adding a couple of seconds in network round trip to
browse to the project, go to issues, click create issue, then type a
whole description of the problem because you don't have the context of
what you're trying to reply to, and then manage the issue by adding
tags, target releases, closing it when something is finally merged (and
having the submitter have to open another pull request and keep track of
it)... Urgh.

Good code review provides a positive feedback loop of improvement to
code with a positive reinforcement at the end of "patch merged!"
Contrast this to the negative re-inforcement of filing bugs, of which
there is little to no direct motivation for the code author to go and fix.

-- 
Stewart Smith
OPAL Architect, IBM.