All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Michal Bachraty <michal.bachraty@gmail.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt
Date: Fri, 18 Jan 2013 14:27:20 +0100	[thread overview]
Message-ID: <87ip6uiptz.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAAfrEwaoFxRON0dJceMXeGEG-=tgUmqThEcwid2wiiLWTJYE-A@mail.gmail.com> (Michal Bachraty's message of "Fri, 18 Jan 2013 13:22:32 +0100")

>>>>> "Michal" == Michal Bachraty <michal.bachraty@gmail.com> writes:

Hi,

 Michal> I'm ok with your changes. Have you tried to set MAC from
 Michal> u-boot? I haven't seen any code for that purpose in cpsw. I
 Michal> tried put MAC with kernel command parameter (in u-boot), but
 Michal> nothing happen.

I didn't actually try, but mainline U-Boot has support for updating the
mac-address properties if you:

 - build U-Boot with dt support (CONFIG_OF_LIBFDT)
 - use a seperate .dtb file
 - add aliases called ethernet{0,1} to the 2 cpsw slaves in the dts
   (this should arguable be done in am33xx.dtsi) - E.G.:

 aliases {
   ..
   ethernet0 = &cpsw_emac0;
   ethernet1 = &cpsw_emac1;
 };

Then U-boot will set the mac-address properties to the content of the
ethaddr / eth1addr environment variables. See fdt_fixup_ethernet() for
details.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2013-01-18 13:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 21:01 [PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt Peter Korsgaard
2013-01-17 15:14 ` Michal Bachraty
2013-01-17 16:43   ` Peter Korsgaard
2013-01-17 16:43     ` Peter Korsgaard
2013-01-17 17:45     ` Tony Lindgren
2013-01-17 17:45       ` Tony Lindgren
2013-01-17 22:19       ` Peter Korsgaard
2013-01-17 22:19         ` Peter Korsgaard
2013-01-18  8:23         ` Michal Bachraty
2013-01-18  8:23           ` Michal Bachraty
     [not found]     ` <CAAfrEwYGMwVfxD2z6xKfzyn-252B2UT0AuxD36rZsct11Pi52w@mail.gmail.com>
     [not found]       ` <87obgmkhs2.fsf@dell.be.48ers.dk>
     [not found]         ` <CAAfrEwaoFxRON0dJceMXeGEG-=tgUmqThEcwid2wiiLWTJYE-A@mail.gmail.com>
2013-01-18 13:27           ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip6uiptz.fsf@dell.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=linux-omap@vger.kernel.org \
    --cc=michal.bachraty@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.