From: Tony Lindgren <tony@atomide.com>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: Michal Bachraty <michal.bachraty@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt
Date: Thu, 17 Jan 2013 09:45:29 -0800 [thread overview]
Message-ID: <20130117174528.GM14149@atomide.com> (raw)
In-Reply-To: <87a9s7lq09.fsf@dell.be.48ers.dk>
* Peter Korsgaard <jacmet@sunsite.dk> [130117 08:46]:
> >>>>> "Michal" == Michal Bachraty <michal.bachraty@gmail.com> writes:
>
> Hi Michael,
>
> Michal> I made changes to cpsw driver two weeks ago, which add support
> Michal> for reading MAC address from CPU and also I posted it to
> Michal> review. You can find patch here :
> Michal> https://patchwork.kernel.org/patch/1966481/ I will create
> Michal> updated patch next week, depended on reactions. Can you try
> Michal> that patch? I'll be glad to hear your opinion.
>
> Thanks, I missed that patch. Functionality wise the patches do the same,
> but I must say I find my patch cleaner, as it doesn't involve any new dt
> bindings or access to the am33xx specific control module registers from
> the cpsw driver.
>
> The way I've handled it is similar to how it is done on atleast one
> other arm subarchicture, see
> arch/arm/mach-mxs/mach-mxs.c::update_fec_mac_prop()
Cool this seems like the cleanest way to deal with it so far. Can
you please resend with also linux-net and DT list Cc:d too?
Also the arch_initcall should be omap_arch_initcall in linux next
for consistency if we ever have SoC specific sections for those.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt
Date: Thu, 17 Jan 2013 09:45:29 -0800 [thread overview]
Message-ID: <20130117174528.GM14149@atomide.com> (raw)
In-Reply-To: <87a9s7lq09.fsf@dell.be.48ers.dk>
* Peter Korsgaard <jacmet@sunsite.dk> [130117 08:46]:
> >>>>> "Michal" == Michal Bachraty <michal.bachraty@gmail.com> writes:
>
> Hi Michael,
>
> Michal> I made changes to cpsw driver two weeks ago, which add support
> Michal> for reading MAC address from CPU and also I posted it to
> Michal> review. You can find patch here :
> Michal> https://patchwork.kernel.org/patch/1966481/ I will create
> Michal> updated patch next week, depended on reactions. Can you try
> Michal> that patch? I'll be glad to hear your opinion.
>
> Thanks, I missed that patch. Functionality wise the patches do the same,
> but I must say I find my patch cleaner, as it doesn't involve any new dt
> bindings or access to the am33xx specific control module registers from
> the cpsw driver.
>
> The way I've handled it is similar to how it is done on atleast one
> other arm subarchicture, see
> arch/arm/mach-mxs/mach-mxs.c::update_fec_mac_prop()
Cool this seems like the cleanest way to deal with it so far. Can
you please resend with also linux-net and DT list Cc:d too?
Also the arch_initcall should be omap_arch_initcall in linux next
for consistency if we ever have SoC specific sections for those.
Regards,
Tony
next prev parent reply other threads:[~2013-01-17 17:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 21:01 [PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt Peter Korsgaard
2013-01-17 15:14 ` Michal Bachraty
2013-01-17 16:43 ` Peter Korsgaard
2013-01-17 16:43 ` Peter Korsgaard
2013-01-17 17:45 ` Tony Lindgren [this message]
2013-01-17 17:45 ` Tony Lindgren
2013-01-17 22:19 ` Peter Korsgaard
2013-01-17 22:19 ` Peter Korsgaard
2013-01-18 8:23 ` Michal Bachraty
2013-01-18 8:23 ` Michal Bachraty
[not found] ` <CAAfrEwYGMwVfxD2z6xKfzyn-252B2UT0AuxD36rZsct11Pi52w@mail.gmail.com>
[not found] ` <87obgmkhs2.fsf@dell.be.48ers.dk>
[not found] ` <CAAfrEwaoFxRON0dJceMXeGEG-=tgUmqThEcwid2wiiLWTJYE-A@mail.gmail.com>
2013-01-18 13:27 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117174528.GM14149@atomide.com \
--to=tony@atomide.com \
--cc=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=michal.bachraty@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.