All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com, rnayak@ti.com,
	linux-arm-kernel@lists.infradead.org,
	Afzal Mohammed <afzal@ti.com>
Subject: Re: [PATCH-V2 1/2] arm:omap:am33xx: Add voltage domain data
Date: Tue, 10 Jan 2012 10:29:59 -0800	[thread overview]
Message-ID: <87ipkjpg0o.fsf@ti.com> (raw)
In-Reply-To: <1324803628-16790-2-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Sun, 25 Dec 2011 14:30:27 +0530")

Vaibhav Hiremath <hvaibhav@ti.com> writes:

> Currently dummy voltage domain data is being created
> in order to succeed boot process, nothing has been done
> w.r.t actual hardware (voltage control).
>
> Also, hook up the AM33XX voltage domain to OMAP framework.
>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>

Data looks OK, but why the dummy voltage domains?   Does this device not
support voltage scaling? 

Also, I think it was my idea in an earlier review to add the 
'.scalable = false', but it's not really necessary since the default is
false.  Sorry 'bout that.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-V2 1/2] arm:omap:am33xx: Add voltage domain data
Date: Tue, 10 Jan 2012 10:29:59 -0800	[thread overview]
Message-ID: <87ipkjpg0o.fsf@ti.com> (raw)
In-Reply-To: <1324803628-16790-2-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Sun, 25 Dec 2011 14:30:27 +0530")

Vaibhav Hiremath <hvaibhav@ti.com> writes:

> Currently dummy voltage domain data is being created
> in order to succeed boot process, nothing has been done
> w.r.t actual hardware (voltage control).
>
> Also, hook up the AM33XX voltage domain to OMAP framework.
>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>

Data looks OK, but why the dummy voltage domains?   Does this device not
support voltage scaling? 

Also, I think it was my idea in an earlier review to add the 
'.scalable = false', but it's not really necessary since the default is
false.  Sorry 'bout that.

Kevin

  reply	other threads:[~2012-01-10 18:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-25  9:00 [PATCH-V2 0/2] arm:omap:am33xx: Add voltage and power domain data Vaibhav Hiremath
2011-12-25  9:00 ` Vaibhav Hiremath
2011-12-25  9:00 ` [PATCH-V2 1/2] arm:omap:am33xx: Add voltage " Vaibhav Hiremath
2011-12-25  9:00   ` Vaibhav Hiremath
2012-01-10 18:29   ` Kevin Hilman [this message]
2012-01-10 18:29     ` Kevin Hilman
2012-01-11 16:26     ` Hiremath, Vaibhav
2012-01-11 16:26       ` Hiremath, Vaibhav
2011-12-25  9:00 ` [PATCH-V2 2/2] arm:omap:am33xx: Add power " Vaibhav Hiremath
2011-12-25  9:00   ` Vaibhav Hiremath
2012-03-01  1:37   ` Paul Walmsley
2012-03-01  1:37     ` Paul Walmsley
2012-03-01 10:42     ` Hiremath, Vaibhav
2012-03-01 10:42       ` Hiremath, Vaibhav
2012-03-02  5:49       ` Paul Walmsley
2012-03-02  5:49         ` Paul Walmsley
2012-03-02  5:58         ` Hiremath, Vaibhav
2012-03-02  5:58           ` Hiremath, Vaibhav
2012-03-01  1:44   ` Paul Walmsley
2012-03-01  1:44     ` Paul Walmsley
2012-03-01 10:54     ` Hiremath, Vaibhav
2012-03-01 10:54       ` Hiremath, Vaibhav
2012-03-02  6:32       ` Paul Walmsley
2012-03-02  6:32         ` Paul Walmsley
2012-03-02  6:37         ` Hiremath, Vaibhav
2012-03-02  6:37           ` Hiremath, Vaibhav
2012-03-02 10:46           ` Paul Walmsley
2012-03-02 10:46             ` Paul Walmsley
2012-03-08 16:39             ` Hiremath, Vaibhav
2012-03-08 16:39               ` Hiremath, Vaibhav
2012-01-10 23:39 ` [PATCH-V2 0/2] arm:omap:am33xx: Add voltage and " Kevin Hilman
2012-01-10 23:39   ` Kevin Hilman
2012-01-11 16:27   ` Hiremath, Vaibhav
2012-01-11 16:27     ` Hiremath, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipkjpg0o.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=afzal@ti.com \
    --cc=hvaibhav@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.