From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-trivial] [PATCH] hw/9pfs: Fix missing parentheses
Date: Tue, 18 Oct 2011 10:40:39 +0530 [thread overview]
Message-ID: <87ipnm7uls.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1318879259-3052-1-git-send-email-sw@weilnetz.de>
On Mon, 17 Oct 2011 21:20:59 +0200, Stefan Weil <sw@weilnetz.de> wrote:
> cppcheck report:
> hw/9pfs/virtio-9p.c:2385:
> style: Boolean result is used in bitwise operation.
> Clarify expression with parentheses
> hw/9pfs/virtio-9p.c:2531:
> style: Boolean result is used in bitwise operation.
> Clarify expression with parentheses
>
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/9pfs/virtio-9p.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index c01c31a..df0b22a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -2382,7 +2382,7 @@ static void v9fs_remove(void *opaque)
> goto out_nofid;
> }
> /* if fs driver is not path based, return EOPNOTSUPP */
> - if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> + if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
> err = -EOPNOTSUPP;
> goto out_err;
> }
> @@ -2528,7 +2528,7 @@ static void v9fs_rename(void *opaque)
> }
> BUG_ON(fidp->fid_type != P9_FID_NONE);
> /* if fs driver is not path based, return EOPNOTSUPP */
> - if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> + if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
> err = -EOPNOTSUPP;
> goto out;
> }
This is fixed in the new pull request i sent.
http://article.gmane.org/gmane.comp.emulators.qemu/120990
http://repo.or.cz/w/qemu/v9fs.git/commitdiff/c98f1d4a8bb6f779313043d2490093451cf52065?hp=7cca27dfde6435a7846d88e8a1fa927d0ab99919
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Fix missing parentheses
Date: Tue, 18 Oct 2011 10:40:39 +0530 [thread overview]
Message-ID: <87ipnm7uls.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1318879259-3052-1-git-send-email-sw@weilnetz.de>
On Mon, 17 Oct 2011 21:20:59 +0200, Stefan Weil <sw@weilnetz.de> wrote:
> cppcheck report:
> hw/9pfs/virtio-9p.c:2385:
> style: Boolean result is used in bitwise operation.
> Clarify expression with parentheses
> hw/9pfs/virtio-9p.c:2531:
> style: Boolean result is used in bitwise operation.
> Clarify expression with parentheses
>
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/9pfs/virtio-9p.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index c01c31a..df0b22a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -2382,7 +2382,7 @@ static void v9fs_remove(void *opaque)
> goto out_nofid;
> }
> /* if fs driver is not path based, return EOPNOTSUPP */
> - if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> + if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
> err = -EOPNOTSUPP;
> goto out_err;
> }
> @@ -2528,7 +2528,7 @@ static void v9fs_rename(void *opaque)
> }
> BUG_ON(fidp->fid_type != P9_FID_NONE);
> /* if fs driver is not path based, return EOPNOTSUPP */
> - if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> + if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
> err = -EOPNOTSUPP;
> goto out;
> }
This is fixed in the new pull request i sent.
http://article.gmane.org/gmane.comp.emulators.qemu/120990
http://repo.or.cz/w/qemu/v9fs.git/commitdiff/c98f1d4a8bb6f779313043d2490093451cf52065?hp=7cca27dfde6435a7846d88e8a1fa927d0ab99919
-aneesh
next prev parent reply other threads:[~2011-10-18 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 19:20 [Qemu-trivial] [PATCH] hw/9pfs: Fix missing parentheses Stefan Weil
2011-10-17 19:20 ` [Qemu-devel] " Stefan Weil
2011-10-18 5:10 ` Aneesh Kumar K.V [this message]
2011-10-18 5:10 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipnm7uls.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.