From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
Date: Sun, 03 Apr 2011 13:26:35 +0200 [thread overview]
Message-ID: <87ipuvr2xg.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <E1Q5x0g-0001Yw-Vb@rmk-PC.arm.linux.org.uk> (Russell King's message of "Sat, 02 Apr 2011 10:20:46 +0100")
Hi,
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> CONFIG_PM is now set whenever we support either runtime PM in addition
> to suspend and hibernate. This causes build errors when runtime PM is
> enabled on a platform, but the CPU does not have the appropriate support
> for suspend.
>
> So, switch this code to use CONFIG_PM_SLEEP rather than CONFIG_PM to
> allow runtime PM to be enabled without causing build errors.
I've build-tested on some failing platforms theses 2 patches and the
build are now succeeding. The only PM related zImage build error I found
was for s5pc100:
arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such file or directory
S5PC100 is a armv7 that's why it's still selected. I guess it will still
need some extra care unless the pm-core.h file is provided. One can try
use the same file as for s5pv210.h. I guess that it has probably not be
done because it was not working (I'm even wondering the differences
between s5pc100 and s5pv210 but this has nothing to do with our current
build troubles).
Arnaud
WARNING: multiple messages have this Message-ID (diff)
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
Date: Sun, 03 Apr 2011 13:26:35 +0200 [thread overview]
Message-ID: <87ipuvr2xg.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <E1Q5x0g-0001Yw-Vb@rmk-PC.arm.linux.org.uk> (Russell King's message of "Sat, 02 Apr 2011 10:20:46 +0100")
Hi,
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> CONFIG_PM is now set whenever we support either runtime PM in addition
> to suspend and hibernate. This causes build errors when runtime PM is
> enabled on a platform, but the CPU does not have the appropriate support
> for suspend.
>
> So, switch this code to use CONFIG_PM_SLEEP rather than CONFIG_PM to
> allow runtime PM to be enabled without causing build errors.
I've build-tested on some failing platforms theses 2 patches and the
build are now succeeding. The only PM related zImage build error I found
was for s5pc100:
arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such file or directory
S5PC100 is a armv7 that's why it's still selected. I guess it will still
need some extra care unless the pm-core.h file is provided. One can try
use the same file as for s5pv210.h. I guess that it has probably not be
done because it was not working (I'm even wondering the differences
between s5pc100 and s5pv210 but this has nothing to do with our current
build troubles).
Arnaud
next prev parent reply other threads:[~2011-04-03 11:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 2:09 [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100 Kukjin Kim
2011-04-02 2:09 ` Kukjin Kim
2011-04-02 9:19 ` Russell King - ARM Linux
2011-04-02 9:19 ` Russell King - ARM Linux
2011-04-02 9:20 ` [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP Russell King - ARM Linux
2011-04-02 9:20 ` Russell King - ARM Linux
2011-04-03 11:26 ` Arnaud Patard [this message]
2011-04-03 11:26 ` Arnaud Patard (Rtp)
2011-04-03 12:27 ` Russell King - ARM Linux
2011-04-03 12:27 ` Russell King - ARM Linux
2011-04-04 11:50 ` Kukjin Kim
2011-04-04 11:50 ` Kukjin Kim
2011-04-02 9:21 ` [PATCH 2/2] ARM: Only allow PM_SLEEP with CPUs which support suspend Russell King - ARM Linux
2011-04-02 9:21 ` Russell King - ARM Linux
2011-04-04 11:47 ` [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100 Kukjin Kim
2011-04-04 11:47 ` Kukjin Kim
2011-04-28 18:43 ` Russell King - ARM Linux
2011-04-28 18:43 ` Russell King - ARM Linux
2011-05-02 1:09 ` Kukjin Kim
2011-05-02 1:09 ` Kukjin Kim
2011-05-12 9:05 ` Russell King - ARM Linux
2011-05-12 9:05 ` Russell King - ARM Linux
2011-05-16 7:15 ` Kukjin Kim
2011-05-16 7:15 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipuvr2xg.fsf@lebrac.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.