From: Andi Kleen <andi@firstfloor.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
Adam Litke <agl@us.ibm.com>, Avi Kivity <avi@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/7] Memory compaction core
Date: Wed, 06 Jan 2010 22:37:22 +0100 [thread overview]
Message-ID: <87iqbeykx9.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1262795169-9095-5-git-send-email-mel@csn.ul.ie> (Mel Gorman's message of "Wed, 6 Jan 2010 16:26:06 +0000")
Mel Gorman <mel@csn.ul.ie> writes:
Haven't reviewed the full thing, but one thing I noticed below:
> +
> + /*
> + * Isolate free pages until enough are available to migrate the
> + * pages on cc->migratepages. We stop searching if the migrate
> + * and free page scanners meet or enough free pages are isolated.
> + */
> + spin_lock_irq(&zone->lock);
Won't that cause very long lock hold times on large zones?
Presumably you need some kind of lock break heuristic.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
Adam Litke <agl@us.ibm.com>, Avi Kivity <avi@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/7] Memory compaction core
Date: Wed, 06 Jan 2010 22:37:22 +0100 [thread overview]
Message-ID: <87iqbeykx9.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1262795169-9095-5-git-send-email-mel@csn.ul.ie> (Mel Gorman's message of "Wed, 6 Jan 2010 16:26:06 +0000")
Mel Gorman <mel@csn.ul.ie> writes:
Haven't reviewed the full thing, but one thing I noticed below:
> +
> + /*
> + * Isolate free pages until enough are available to migrate the
> + * pages on cc->migratepages. We stop searching if the migrate
> + * and free page scanners meet or enough free pages are isolated.
> + */
> + spin_lock_irq(&zone->lock);
Won't that cause very long lock hold times on large zones?
Presumably you need some kind of lock break heuristic.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-06 21:37 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 16:26 [RFC-PATCH 0/7] Memory Compaction v1 Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-06 16:26 ` [PATCH 1/7] Allow CONFIG_MIGRATION to be set without CONFIG_NUMA Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-07 21:46 ` David Rientjes
2010-01-07 21:46 ` David Rientjes
2010-01-07 22:04 ` Christoph Lameter
2010-01-07 22:04 ` Christoph Lameter
2010-01-19 13:00 ` Mel Gorman
2010-01-19 13:00 ` Mel Gorman
2010-01-06 16:26 ` [PATCH 2/7] Export unusable free space index via /proc/pagetypeinfo Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-06 17:10 ` Adam Litke
2010-01-06 17:10 ` Adam Litke
2010-01-06 17:29 ` Mel Gorman
2010-01-06 17:29 ` Mel Gorman
2010-01-06 23:21 ` Tim Pepper
2010-01-06 23:21 ` Tim Pepper
2010-01-28 22:27 ` David Rientjes
2010-01-28 22:27 ` David Rientjes
2010-02-05 10:23 ` Mel Gorman
2010-02-05 10:23 ` Mel Gorman
2010-02-05 21:40 ` David Rientjes
2010-02-05 21:40 ` David Rientjes
2010-02-08 12:10 ` Mel Gorman
2010-02-08 12:10 ` Mel Gorman
2010-01-06 16:26 ` [PATCH 3/7] Export fragmentation " Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-06 16:26 ` [PATCH 4/7] Memory compaction core Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-06 17:50 ` Mel Gorman
2010-01-06 17:50 ` Mel Gorman
2010-01-06 18:22 ` Mel Gorman
2010-01-06 18:22 ` Mel Gorman
2010-01-06 21:37 ` Andi Kleen [this message]
2010-01-06 21:37 ` Andi Kleen
2010-01-06 22:07 ` Mel Gorman
2010-01-06 22:07 ` Mel Gorman
2010-01-06 16:26 ` [PATCH 5/7] Add /proc trigger for memory compaction Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-07 22:00 ` David Rientjes
2010-01-07 22:00 ` David Rientjes
2010-01-13 23:23 ` David Rientjes
2010-01-13 23:23 ` David Rientjes
2010-01-20 9:48 ` Mel Gorman
2010-01-20 9:48 ` Mel Gorman
2010-01-20 9:48 ` Mel Gorman
2010-01-20 9:48 ` Mel Gorman
2010-01-20 18:12 ` Christoph Lameter
2010-01-20 18:12 ` Christoph Lameter
2010-01-20 20:53 ` Mel Gorman
2010-01-20 20:53 ` Mel Gorman
2010-01-20 20:48 ` David Rientjes
2010-01-20 20:48 ` David Rientjes
2010-01-21 14:09 ` Mel Gorman
2010-01-21 14:09 ` Mel Gorman
2010-01-21 23:34 ` David Rientjes
2010-01-21 23:34 ` David Rientjes
2010-01-06 16:26 ` [PATCH 6/7] Direct compact when a high-order allocation fails Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-06 16:26 ` [PATCH 7/7] Do not compact within a preferred zone after a compaction failure Mel Gorman
2010-01-06 16:26 ` Mel Gorman
2010-01-13 23:28 ` David Rientjes
2010-01-13 23:28 ` David Rientjes
2010-01-20 9:51 ` Mel Gorman
2010-01-20 9:51 ` Mel Gorman
2010-01-21 3:12 ` [RFC-PATCH 0/7] Memory Compaction v1 KOSAKI Motohiro
2010-01-21 3:12 ` KOSAKI Motohiro
2010-01-21 10:11 ` Mel Gorman
2010-01-21 10:11 ` Mel Gorman
2010-01-22 0:16 ` KOSAKI Motohiro
2010-01-22 0:16 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqbeykx9.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=aarcange@redhat.com \
--cc=agl@us.ibm.com \
--cc=avi@redhat.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.