[Qemu-devel] Re: [PATCH 5/9] monitor: QError support

[Markus Armbruster <armbru@redhat.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 10/13/2009 11:59 PM, Markus Armbruster wrote:
>>> >  +void qemu_error_structed(QErrorCode code, const char *fmt, ...);
>> Needs __attribute__((format(printf, 2, 3))).
>
> If I read the code correctly, qemu_object_from_va is what in the end
> processes the valist and it is not exactly compatible with printf
> syntax.  For example, in patch 7/9 you have
>
>      qemu_error_structed(QERR_QDEV_NFOUND, "{ s: s }", "name", driver);

You're right, of course.

Pity we lose the checking.