All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@saeurebad.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@elte.hu,
	davem@davemloft.net, hskinnemoen@atmel.com, cooloney@kernel.org,
	starvik@axis.com, dhowells@redhat.com,
	ysato@users.sourceforge.net, takata@linux-m32r.org,
	geert@linux-m68k.org, ralf@linux-mips.org, kyle@parisc-linux.org,
	paulus@samba.org, schwidefsky@de.ibm.com, lethal@linux-sh.org,
	jdike@addtoit.com, miles@gnu.org, chris@zankel.net,
	rmk@arm.linux.org.uk, tony.luck@intel.com
Subject: Re: [RFC 17/22] s390: Use generic show_mem()
Date: Thu, 03 Apr 2008 15:00:22 +0200	[thread overview]
Message-ID: <87iqyzozyx.fsf@saeurebad.de> (raw)
In-Reply-To: <20080403075029.GB4125@osiris.boeblingen.de.ibm.com> (Heiko Carstens's message of "Thu, 3 Apr 2008 09:50:29 +0200")

Hi,

Heiko Carstens <heiko.carstens@de.ibm.com> writes:

>> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
>> index 8053245..27b94cb 100644
>> --- a/arch/s390/mm/init.c
>> +++ b/arch/s390/mm/init.c
>> @@ -42,42 +42,6 @@ DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
>>  pgd_t swapper_pg_dir[PTRS_PER_PGD] __attribute__((__aligned__(PAGE_SIZE)));
>>  char  empty_zero_page[PAGE_SIZE] __attribute__((__aligned__(PAGE_SIZE)));
>> 
>> -	printk("Free swap:       %6ldkB\n", nr_swap_pages << (PAGE_SHIFT - 10));
>> -	printk("%lu pages dirty\n", global_page_state(NR_FILE_DIRTY));
>> -	printk("%lu pages writeback\n", global_page_state(NR_WRITEBACK));
>> -	printk("%lu pages mapped\n", global_page_state(NR_FILE_MAPPED));
>> -	printk("%lu pages slab\n",
>> -	       global_page_state(NR_SLAB_RECLAIMABLE) +
>> -	       global_page_state(NR_SLAB_UNRECLAIMABLE));
>> -	printk("%lu pages pagetables\n", global_page_state(NR_PAGETABLE));
>
> These are all missing in the generic implementation.

These are all duplicates from show_free_areas().

Thanks,

	Hannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@saeurebad.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@elte.hu,
	davem@davemloft.net, hskinnemoen@atmel.com, cooloney@kernel.org,
	starvik@axis.com, dhowells@redhat.com, ysato@users.sf.net,
	takata@linux-m32r.org, geert@linux-m68k.org, ralf@linux-mips.org,
	kyle@parisc-linux.org, paulus@samba.org, schwidefsky@de.ibm.com,
	lethal@linux-sh.org, jdike@addtoit.com, miles@gnu.org,
	chris@zankel.net, rmk@arm.linux.org.uk, tony.luck@intel.com
Subject: Re: [RFC 17/22] s390: Use generic show_mem()
Date: Thu, 03 Apr 2008 15:00:22 +0200	[thread overview]
Message-ID: <87iqyzozyx.fsf@saeurebad.de> (raw)
In-Reply-To: <20080403075029.GB4125@osiris.boeblingen.de.ibm.com> (Heiko Carstens's message of "Thu, 3 Apr 2008 09:50:29 +0200")

Hi,

Heiko Carstens <heiko.carstens@de.ibm.com> writes:

>> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
>> index 8053245..27b94cb 100644
>> --- a/arch/s390/mm/init.c
>> +++ b/arch/s390/mm/init.c
>> @@ -42,42 +42,6 @@ DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
>>  pgd_t swapper_pg_dir[PTRS_PER_PGD] __attribute__((__aligned__(PAGE_SIZE)));
>>  char  empty_zero_page[PAGE_SIZE] __attribute__((__aligned__(PAGE_SIZE)));
>> 
>> -	printk("Free swap:       %6ldkB\n", nr_swap_pages << (PAGE_SHIFT - 10));
>> -	printk("%lu pages dirty\n", global_page_state(NR_FILE_DIRTY));
>> -	printk("%lu pages writeback\n", global_page_state(NR_WRITEBACK));
>> -	printk("%lu pages mapped\n", global_page_state(NR_FILE_MAPPED));
>> -	printk("%lu pages slab\n",
>> -	       global_page_state(NR_SLAB_RECLAIMABLE) +
>> -	       global_page_state(NR_SLAB_UNRECLAIMABLE));
>> -	printk("%lu pages pagetables\n", global_page_state(NR_PAGETABLE));
>
> These are all missing in the generic implementation.

These are all duplicates from show_free_areas().

Thanks,

	Hannes

  reply	other threads:[~2008-04-03 13:00 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02 20:40 [RFC 00/21] Generic show_mem() Johannes Weiner
2008-04-02 20:40 ` Johannes Weiner
2008-04-02 20:40 ` [RFC 01/22] Generic show_mem() implementation Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-03  7:55   ` Heiko Carstens
2008-04-03  7:55     ` Heiko Carstens
2008-04-03 12:48     ` Sam Ravnborg
2008-04-03 12:48       ` Sam Ravnborg
2008-04-03 13:30       ` Johannes Weiner
2008-04-03 13:30         ` Johannes Weiner
2008-04-03 14:49       ` Johannes Weiner
2008-04-03 14:49         ` Johannes Weiner
2008-04-03 18:12         ` Sam Ravnborg
2008-04-03 18:12           ` Sam Ravnborg
2008-04-03 22:33           ` Johannes Weiner
2008-04-03 22:33             ` Johannes Weiner
2008-04-04 21:35             ` Sam Ravnborg
2008-04-04 21:35               ` Sam Ravnborg
2008-04-04 23:10               ` Johannes Weiner
2008-04-04 23:10                 ` Johannes Weiner
2008-04-05  7:51                 ` Heiko Carstens
2008-04-05  7:51                   ` Heiko Carstens
2008-04-05  9:04                   ` Ralf Baechle
2008-04-05 17:52                     ` Heiko Carstens
2008-04-03 12:18   ` Ralf Baechle
2008-04-02 20:40 ` [RFC 02/22] x86: Use generic show_mem() Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-04  8:17   ` Ingo Molnar
2008-04-04  8:17     ` Ingo Molnar
2008-04-02 20:40 ` [RFC 03/22] sparc64: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 04/22] avr32: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 05/22] blackfin: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 06/22] cris: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 07/22] frv: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 08/22] h8300: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 09/22] m32r: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 10/22] m68k: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-03  7:40   ` Geert Uytterhoeven
2008-04-03 12:58     ` Johannes Weiner
2008-04-03 13:39       ` Geert Uytterhoeven
2008-04-03 15:10         ` Johannes Weiner
2008-04-03 16:07           ` Hugh Dickins
2008-04-03 16:17             ` Johannes Weiner
2008-04-03 19:13             ` Geert Uytterhoeven
2008-04-02 20:40 ` [RFC 11/22] m68knommu: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 12/22] mips: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-03 11:59   ` Ralf Baechle
2008-04-02 20:40 ` [RFC 13/22] mn10300: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 14/22] parisc: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 15/22] powerpc: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 16/22] ppc: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 17/22] s390: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-03  7:50   ` Heiko Carstens
2008-04-03  7:50     ` Heiko Carstens
2008-04-03 13:00     ` Johannes Weiner [this message]
2008-04-03 13:00       ` Johannes Weiner
2008-04-03 17:58       ` Heiko Carstens
2008-04-03 17:58         ` Heiko Carstens
2008-04-03 22:37         ` Johannes Weiner
2008-04-03 22:37           ` Johannes Weiner
2008-04-04  7:39           ` Heiko Carstens
2008-04-04  7:39             ` Heiko Carstens
2008-04-02 20:40 ` [RFC 18/22] sh: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-03 11:41   ` Paul Mundt
2008-04-03 11:41     ` Paul Mundt
2008-04-03 13:08     ` Johannes Weiner
2008-04-03 13:08       ` Johannes Weiner
2008-04-02 20:40 ` [RFC 19/22] um: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-04 14:38   ` Jeff Dike
2008-04-02 20:40 ` [RFC 20/22] v850: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 21/22] xtensa: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-02 20:40 ` [RFC 22/22] alpha: " Johannes Weiner
2008-04-02 20:40   ` Johannes Weiner
2008-04-03 23:45 ` [RFC 00/21] Generic show_mem() Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iqyzozyx.fsf@saeurebad.de \
    --to=hannes@saeurebad.de \
    --cc=chris@zankel.net \
    --cc=cooloney@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hskinnemoen@atmel.com \
    --cc=jdike@addtoit.com \
    --cc=kyle@parisc-linux.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miles@gnu.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=ysato@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.