* [PATCH] remove version.h from bttv @ 2003-08-11 13:40 davej 2003-08-11 16:30 ` Gerd Knorr 0 siblings, 1 reply; 3+ messages in thread From: davej @ 2003-08-11 13:40 UTC (permalink / raw) To: torvalds; +Cc: linux-kernel diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/media/video/bttvp.h linux-2.5/drivers/media/video/bttvp.h --- bk-linus/drivers/media/video/bttvp.h 2003-08-07 19:45:39.000000000 +0100 +++ linux-2.5/drivers/media/video/bttvp.h 2003-08-07 22:20:17.000000000 +0100 @@ -24,7 +24,7 @@ #ifndef _BTTVP_H_ #define _BTTVP_H_ -#include <linux/version.h> + #define BTTV_VERSION_CODE KERNEL_VERSION(0,9,11) #include <linux/types.h> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove version.h from bttv 2003-08-11 13:40 [PATCH] remove version.h from bttv davej @ 2003-08-11 16:30 ` Gerd Knorr 2003-08-11 16:56 ` Valdis.Kletnieks 0 siblings, 1 reply; 3+ messages in thread From: Gerd Knorr @ 2003-08-11 16:30 UTC (permalink / raw) To: linux-kernel davej@redhat.com writes: > -#include <linux/version.h> > + > #define BTTV_VERSION_CODE KERNEL_VERSION(0,9,11) ^^^^^^^^^^^^^^ I'm pretty sure this will break the build ... Gerd -- sigfault ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove version.h from bttv 2003-08-11 16:30 ` Gerd Knorr @ 2003-08-11 16:56 ` Valdis.Kletnieks 0 siblings, 0 replies; 3+ messages in thread From: Valdis.Kletnieks @ 2003-08-11 16:56 UTC (permalink / raw) To: Gerd Knorr; +Cc: linux-kernel [-- Attachment #1: Type: text/plain, Size: 388 bytes --] On Mon, 11 Aug 2003 18:30:54 +0200, Gerd Knorr <kraxel@bytesex.org> said: > davej@redhat.com writes: > > > -#include <linux/version.h> > > + > > #define BTTV_VERSION_CODE KERNEL_VERSION(0,9,11) > ^^^^^^^^^^^^^^ > > I'm pretty sure this will break the build ... Not if all consumers of that .h file have already #included version.h (perhaps indirectly). [-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-08-11 17:01 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2003-08-11 13:40 [PATCH] remove version.h from bttv davej 2003-08-11 16:30 ` Gerd Knorr 2003-08-11 16:56 ` Valdis.Kletnieks
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.